Add support for handling zarr urls - #7113
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7113 +/- ##
==========================================
+ Coverage 90.32% 90.34% +0.02%
==========================================
Files 92 92
Lines 25284 25342 +58
Branches 4719 4731 +12
==========================================
+ Hits 22838 22896 +58
Misses 1675 1675
Partials 771 771 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Some NotesSince @pp-mo @stephenworsley discussed this yesterday, here's my take on some things we found...
|
There was a problem hiding this comment.
Templating
This PR includes changes that may be worth sharing via templating. For each file listed below, please either:
- Action the suggestion via a pull request editing/adding the relevant file in the SciTools/.github
templates/directory. 1 - Raise an issue against the SciTools/.github repo for the above action if you really don't have 10mins spare right now. Include an assignee, to avoid it being forgotten.
- Dismiss the suggestion if the changes are not suitable for templating.
You will need to dismiss this review before this PR can be merged. Recommend the reviewer does this as their final action before merging, as this text will continually update as commits come in.
Template candidates
The following changed files are not currently templated, but their parent directories suggest they may be good candidates for a new template to be created:
Footnotes
-
Include this text in the PR body to avoid any notifications about applying the template changes back to the source repo!
@scitools-templating: please no update notification on: iris↩
ukmo-ccbunney
left a comment
There was a problem hiding this comment.
Looking good so far. Just a few suggestions and comments.
ukmo-ccbunney
left a comment
There was a problem hiding this comment.
Just a thought I meant to add to the original review...
Co-authored-by: Chris Bunney <[email protected]>
Co-authored-by: Chris Bunney <[email protected]>
Co-authored-by: Chris Bunney <[email protected]>
Co-authored-by: Chris Bunney <[email protected]>
Co-authored-by: Chris Bunney <[email protected]>
Co-authored-by: Chris Bunney <[email protected]>
ukmo-ccbunney
left a comment
There was a problem hiding this comment.
OK. Everything mostly looks good. I've made a few suggested changes to fix the failing test.
I've also pushed up some whatsnew fragments that Pak Lam and myself put together, see 90236d2
Co-authored-by: Chris Bunney <[email protected]>
Co-authored-by: Chris Bunney <[email protected]>
Co-authored-by: Chris Bunney <[email protected]>
ukmo-ccbunney
left a comment
There was a problem hiding this comment.
Spotted a slight oddity...
ukmo-ccbunney
left a comment
There was a problem hiding this comment.
Thanks for updating the docs with the HDF5 comment.
I think this is all good to go now. 👍🏼
Not relevant - Iris specific.
Closes #6967