Fix bug with mesh indexing for start_index=1 - #7253
Merged
trexfeathers merged 5 commits intoAug 20, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7253 +/- ##
=======================================
Coverage 90.42% 90.42%
=======================================
Files 93 93
Lines 25812 25816 +4
Branches 4795 4796 +1
=======================================
+ Hits 23340 23344 +4
Misses 1693 1693
Partials 779 779 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
stephenworsley
marked this pull request as ready for review
August 20, 2026 12:38
trexfeathers
requested changes
Aug 20, 2026
trexfeathers
left a comment
Contributor
There was a problem hiding this comment.
Thanks @stephenworsley. I have confirmed that this fixes the problems reported in #7246 (and without it I can replicate those problems).
Couple of comments on the tests for you
trexfeathers
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7246.
This ought to fix the problems with face_node_connectivities in #7246, but won't yet address the other connectivities (it might be worth just throwing away these connectivities from the returned MeshIndexSet for the time being). This PR seems to work with the file in #7246 when I experimented with it locally, but this PR will want a bit more testing to ensure coverage for these cases.