Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Error in settings-page if background ctx unavailable#7468

Open
WorldLanguages wants to merge 1 commit intoScratchAddons:masterfrom
WorldLanguages:settings-page-bg-error
Open

Error in settings-page if background ctx unavailable#7468
WorldLanguages wants to merge 1 commit intoScratchAddons:masterfrom
WorldLanguages:settings-page-bg-error

Conversation

@WorldLanguages
Copy link
Member

Resolves #5306

Changes

image

  • The error page is still not localized - so it's English only
  • The popup still doesn't show any error message if the background context is unavailable.

Tests

Tested in Chrome and Firefox on MV3

@WorldLanguages WorldLanguages added type: enhancement New feature for the project scope: core Related to the core script/extension workings labels May 25, 2024
@WorldLanguages WorldLanguages self-assigned this May 25, 2024
@WorldLanguages WorldLanguages requested a review from apple502j as a code owner May 25, 2024 23:32
@WorldLanguages WorldLanguages added this to the v1.39.0 milestone May 29, 2024
@Samq64 Samq64 added the status: needs review PR needs 1 more approval label Jun 4, 2024
@Samq64
Copy link
Member

Samq64 commented Jun 5, 2024

Could the option to export settings be uncommented? I'm going to PR some styles for the page so I could also include it there.

@WorldLanguages
Copy link
Member Author

I think I want to change the "Extension settings are corrupted or temporarily unavailable" wording in this case, and add the export button as Samq said.

@DNin01 DNin01 added the size: small Can be reviewed quickly label Jul 11, 2024
@Samq64
Copy link
Member

Samq64 commented Jul 12, 2024

Could the option to export settings be uncommented?

Replying to myself, for unsupported browsers the buttons were added to the existing page on the website instead of using this one.

@WorldLanguages
Copy link
Member Author

@Samq64 It would be nice to allow users to export their settings in this screen.

@WorldLanguages WorldLanguages modified the milestones: v1.39.0, v1.40.0 Jul 31, 2024
@Samq64 Samq64 modified the milestones: v1.40.0, v1.41.0 Dec 21, 2024
@Samq64 Samq64 removed this from the v1.41.0 milestone Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: core Related to the core script/extension workings size: small Can be reviewed quickly status: needs review PR needs 1 more approval type: enhancement New feature for the project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow more control when Scratch Addons fails to load

3 participants