Exp bdd tests#6965
Merged
Merged
Conversation
f2ff855 to
2d86dd9
Compare
c80c7f6 to
d335607
Compare
ba79efa to
13d559d
Compare
abb6201 to
ddd1a36
Compare
MiguelAAe
commented
Dec 4, 2025
| // Model Deployments | ||
| ctx.Step(`^the model is applied$`, w.ApplyModel) | ||
| // Model Assertions | ||
| ctx.Step(`^the model (?:should )?eventually become(?:s)? Ready$`, w.ModelReady) |
Contributor
Author
There was a problem hiding this comment.
Assertions will grow as we need to check for different types of assertions for model status, gateway status etc might be worth implementing some sort of pattern matcher for this type of steps that match regular expression to assertions that are then executed with the Waitfor found here: https://github.com/SeldonIO/seldon-core/pull/6965/files#diff-08a8e491ec85e75d1ee2c67f0009b9303460abb7856178d9a3f2a87f7e4023baR145
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Issues
Motivation
What
Summary of changes
Checklist
Testing