-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
K8s: Template handle scaledJobOptions with value is zero #3054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Viet Nguyen Duc <[email protected]>
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
|||||||||||||||||||||||||||||
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||||||||||
CI Feedback 🧐A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
User description
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Fixed #3050
Key with value 0 is not picked up in template renderring
Motivation and Context
Types of changes
Checklist
PR Type
Bug fix, Tests
Description
Fix template handling of zero-valued scaledJobOptions in Helm charts
Add validation test for ScaledJob template rendering
Update dummy configuration with zero values for testing
Diagram Walkthrough
File Walkthrough
_helpers.tpl
Handle zero values in scaledJobOptions templatecharts/selenium-grid/templates/_helpers.tpl
numeric and boolean fields
not (empty $value)toor (kindIs "float64" $value)(kindIs "int64" $value) (kindIs "bool" $value) (not (empty $value))being filtered out
test_scaled_job.py
Add ScaledJob template validation testtests/charts/templates/test_scaled_job.py
limits
are set to 0
bootstrap.sh
Integrate ScaledJob validation into bootstrap scripttests/charts/bootstrap.sh
dummy_job_template_manifests.yaml
dummy.yaml
Update dummy config with zero-valued optionstests/charts/templates/render/dummy.yaml