Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[dotnet] Annotate nullability on WebDriver.SessionId#15350

Merged
RenderMichael merged 1 commit intoSeleniumHQ:trunkfrom
RenderMichael:nullable-session
Feb 28, 2025
Merged

[dotnet] Annotate nullability on WebDriver.SessionId#15350
RenderMichael merged 1 commit intoSeleniumHQ:trunkfrom
RenderMichael:nullable-session

Conversation

@RenderMichael
Copy link
Contributor

@RenderMichael RenderMichael commented Feb 28, 2025 •
edited by qodo-code-review bot
Loading

User description

Description

Annotate nullability on WebDriver.SessionId and the related interface IHasSessionId.

Motivation and Context

Contributes to #14640

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PR Type

Enhancement

Description

  • Enabled nullable reference types in WebDriver and IHasSessionId.

  • Annotated SessionId property with nullability support.

  • Improved code clarity and null safety in WebDriver.

  • Added #nullable enable directives to relevant files.

Changes walkthrough 📝

Relevant files
Enhancement
IHasSessionId.cs
Enable nullable reference types in `IHasSessionId`             

dotnet/src/webdriver/IHasSessionId.cs

  • Enabled nullable reference types in the file.
  • Added #nullable enable directive at the namespace level.
    		• +2/-0     
    WebDriver.cs
    Enable nullable reference types in `WebDriver`                     

    dotnet/src/webdriver/WebDriver.cs

  • Enabled nullable reference types in the file.
  • Annotated SessionId property for nullability.
  • Removed redundant #nullable restore directive.
  • Improved null safety in Dispose method.
    		• +3/-7     
    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
    •

    @qodo-code-review
    Copy link
    Contributor

    qodo-code-review bot commented Feb 28, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    🎫 Ticket compliance analysis 🔶

    14640 - Partially compliant

    Compliant requirements:

    • Added nullability annotations to WebDriver.SessionId and IHasSessionId
    • Enabled nullable reference types in the modified files

    Non-compliant requirements:

    • Enable Nullable Reference Types in .csproj and bazel files

    Requires further human verification:

    • Verify that the nullability annotations are correct and prevent null reference exceptions in practice
    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Null Assignment

    The SessionId property is set to null! in Dispose method which could potentially cause issues if the property is accessed after disposal. Consider making the property nullable instead.

     
    this.SessionId = null!;

    @qodo-code-review
    Copy link
    Contributor

    qodo-code-review bot commented Feb 28, 2025

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    Possible issue
    Add nullable annotation to property

    Initialize SessionId property with a nullable annotation since it can be null.
    Change the property type to SessionId? to properly reflect nullability.

    dotnet/src/webdriver/WebDriver.cs [192]

    -public SessionId SessionId { get; private set; }
+public SessionId? SessionId { get; private set; }
    • Apply this suggestion
    Suggestion importance[1-10]: 8

    __

    Why: The suggestion correctly identifies that SessionId should be marked as nullable since it can be set to null (as seen in line 742). This improves type safety and makes the nullability explicit in the API.

    		Medium
    • More

    @RenderMichael RenderMichael merged commit 8d25bef into SeleniumHQ:trunk Feb 28, 2025
    10 checks passed
    @RenderMichael RenderMichael deleted the nullable-session branch February 28, 2025 22:14
    sandeepsuryaprasad pushed a commit to sandeepsuryaprasad/selenium that referenced this pull request Mar 23, 2025
    @RenderMichael @sandeepsuryaprasad
    [dotnet] Annotate nullability on WebDriver.SessionId (SeleniumHQ#15350
    6f4508b 
    )
    @renovate renovate bot mentioned this pull request Jul 21, 2025
    Open
    1 task
    @dependabot dependabot bot mentioned this pull request Sep 18, 2025
    Merged
    @dependabot dependabot bot mentioned this pull request Oct 1, 2025
    Closed
    @dependabot dependabot bot mentioned this pull request Oct 24, 2025
    Closed
    This was referenced Dec 21, 2025
    Open
    Closed
    Closed
    Closed
    This was referenced Jan 19, 2026
    Closed
    Closed
    Closed
    Merged
    This was referenced Feb 16, 2026
    Closed
    Closed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    No reviews

    Assignees

    No one assigned

    Labels

    Review effort 1/5

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    1 participant

    @RenderMichael