Codestin Search App

nvborisenko · 2025-04-09T20:07:56Z

User description

💥 What does this PR do?

Before:

public async Task<Intercept> InterceptRequestAsync(Func<BeforeRequestSentEventArgs, Task> handler, AddInterceptOptions? interceptOptions = null, SubscriptionOptions? options = null)

After:

public async Task<Intercept> InterceptRequestAsync(Func<BeforeRequestSentEventArgs, Task> handler, InterceptRequestOptions? options = null)

Actually it is high level API, following the pattern: public Task<T> DoSomethingAsync(DoSomethingOptions? = null)

🔧 Implementation Notes

💡 Additional Considerations

🔄 Types of changes

Breaking change (fix or feature that would cause existing functionality to change)

PR Type

Enhancement, Tests

Description

Refactored network interception APIs for BiDi in .NET bindings.
Introduced high-level API methods for request, response, and auth interception.
Simplified RequestConverter by removing dependency on BiDi.
Added new test cases to validate updated interception functionality.

Changes walkthrough 📝

Relevant files

Enhancement

6 files

Broker.cs Updated `RequestConverter` usage to reflect refactoring	+1/-1
RequestConverter.cs Simplified `RequestConverter` by removing `BiDi` dependency	+1/-8
BrowsingContextNetworkModule.cs `Refactored network interception methods for high-level API`	+21/-9
NetworkModule.HighLevel.cs Added high-level API for network interception in `NetworkModule`	+106/-0
NetworkModule.cs Updated `NetworkModule` to support high-level interception APIs	+1/-28
Request.cs Removed `BiDi` dependency from `Request` class	+1/-41

Tests

1 files

NetworkTest.cs `Updated and added tests for new interception APIs`	+17/-17

Need help?
Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
Check out the documentation for more information.

qodo-code-review · 2025-04-09T20:08:31Z

PR Reviewer Guide 🔍

(Review updated until commit `ed35158`)

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🧪 PR contains tests
🔒 No security concerns identified
⚡ Recommended focus areas for review Code Duplication The InterceptRequestAsync, InterceptResponseAsync, and InterceptAuthAsync methods in both NetworkModule.HighLevel.cs and BrowsingContextNetworkModule.cs contain nearly identical code. Consider extracting common functionality to reduce duplication. public async Task<Intercept> InterceptRequestAsync(Func<InterceptedRequest, Task> handler, InterceptRequestOptions? options = null) { var intercept = await AddInterceptAsync([InterceptPhase.BeforeRequestSent], options).ConfigureAwait(false); await intercept.OnBeforeRequestSentAsync(async req => await handler(new(req.BiDi, req.Context, req.IsBlocked, req.Navigation, req.RedirectCount, req.Request, req.Timestamp, req.Initiator))).ConfigureAwait(false); return intercept; } public async Task<Intercept> InterceptResponseAsync(Func<InterceptedResponse, Task> handler, InterceptResponseOptions? options = null) { var intercept = await AddInterceptAsync([InterceptPhase.ResponseStarted], options).ConfigureAwait(false); await intercept.OnResponseStartedAsync(async res => await handler(new(res.BiDi, res.Context, res.IsBlocked, res.Navigation, res.RedirectCount, res.Request, res.Timestamp, res.Response))).ConfigureAwait(false); return intercept; } public async Task<Intercept> InterceptAuthAsync(Func<InterceptedAuth, Task> handler, InterceptAuthOptions? options = null) { var intercept = await AddInterceptAsync([InterceptPhase.AuthRequired], options).ConfigureAwait(false); await intercept.OnAuthRequiredAsync(async auth => await handler(new(auth.BiDi, auth.Context, auth.IsBlocked, auth.Navigation, auth.RedirectCount, auth.Request, auth.Timestamp, auth.Response))).ConfigureAwait(false); return intercept; } Error Handling The new high-level API methods don't include explicit error handling for cases where the handler might throw exceptions. Consider adding try/catch blocks to ensure proper error propagation. public async Task<Intercept> InterceptRequestAsync(Func<InterceptedRequest, Task> handler, InterceptRequestOptions? options = null) { var intercept = await AddInterceptAsync([InterceptPhase.BeforeRequestSent], options).ConfigureAwait(false); await intercept.OnBeforeRequestSentAsync(async req => await handler(new(req.BiDi, req.Context, req.IsBlocked, req.Navigation, req.RedirectCount, req.Request, req.Timestamp, req.Initiator))).ConfigureAwait(false); return intercept; } public async Task<Intercept> InterceptResponseAsync(Func<InterceptedResponse, Task> handler, InterceptResponseOptions? options = null) { var intercept = await AddInterceptAsync([InterceptPhase.ResponseStarted], options).ConfigureAwait(false); await intercept.OnResponseStartedAsync(async res => await handler(new(res.BiDi, res.Context, res.IsBlocked, res.Navigation, res.RedirectCount, res.Request, res.Timestamp, res.Response))).ConfigureAwait(false); return intercept; } public async Task<Intercept> InterceptAuthAsync(Func<InterceptedAuth, Task> handler, InterceptAuthOptions? options = null) { var intercept = await AddInterceptAsync([InterceptPhase.AuthRequired], options).ConfigureAwait(false); await intercept.OnAuthRequiredAsync(async auth => await handler(new(auth.BiDi, auth.Context, auth.IsBlocked, auth.Navigation, auth.RedirectCount, auth.Request, auth.Timestamp, auth.Response))).ConfigureAwait(false); return intercept; }

qodo-code-review · 2025-04-09T20:09:18Z

PR Code Suggestions ✨

Latest suggestions up to ed35158
Explore these optional code suggestions:

Category	Suggestion	Impact
Learned best practice	Add null parameter validation to prevent potential NullReferenceExceptions The constructor accepts a string parameter `id` which is directly assigned to the `Id` property without any null check. Since the parameter could be null, add a null check using `ArgumentNullException.ThrowIfNull()` to prevent potential NullReferenceExceptions when the `Id` property is accessed later. dotnet/src/webdriver/BiDi/Modules/Network/Request.cs [24-27] internal Request(string id) { + ArgumentNullException.ThrowIfNull(id, nameof(id)); Id = id; } Apply this suggestion Suggestion importance[1-10]: 6	Low
General	Simplify lambda expression The lambda expression is unnecessarily complex with nested awaits. Since you're just passing through the handler call, you can simplify this by directly using the handler as the delegate. dotnet/src/webdriver/BiDi/Modules/BrowsingContext/BrowsingContextNetworkModule.cs [37-39] await intercept.OnBeforeRequestSentAsync( - async req => await handler(new(req.BiDi, req.Context, req.IsBlocked, req.Navigation, req.RedirectCount, req.Request, req.Timestamp, req.Initiator)), + req => handler(new(req.BiDi, req.Context, req.IsBlocked, req.Navigation, req.RedirectCount, req.Request, req.Timestamp, req.Initiator)), new BrowsingContextsSubscriptionOptions(null) { Contexts = [context] }).ConfigureAwait(false); Apply this suggestion Suggestion importance[1-10]: 5 __ Why: The suggestion correctly identifies an unnecessarily complex lambda expression with nested awaits. The proposed simplification removes the redundant async/await keywords while maintaining the same functionality, which improves code readability and reduces overhead.	Low
Update

Previous suggestions

Suggestions up to commit 02ecaed

Category	Suggestion	Impact
Possible issue	Missing subscription options parameter The `OnBeforeRequestSentAsync` method is being called without passing the subscription options, but the original implementation in NetworkModule.cs passed these options. This could lead to different behavior in the new implementation. dotnet/src/webdriver/BiDi/Modules/Network/NetworkModule.HighLevel.cs [27-34] public async Task<Intercept> InterceptRequestAsync(Func<BeforeRequestSentEventArgs, Task> handler, InterceptRequestOptions? options = null) { var intercept = await AddInterceptAsync([InterceptPhase.BeforeRequestSent], options).ConfigureAwait(false); - await intercept.OnBeforeRequestSentAsync(handler).ConfigureAwait(false); + await intercept.OnBeforeRequestSentAsync(handler, options).ConfigureAwait(false); return intercept; } Suggestion importance[1-10]: 8 __ Why: The suggestion correctly identifies a critical issue where the new implementation omits the subscription options parameter when calling OnBeforeRequestSentAsync, which was present in the original code. This could cause different behavior and potentially break existing functionality.	Medium
Learned best practice	Add null validation for required parameters to prevent potential NullReferenceExceptions Add a null check for the `handler` parameter before using it. Since this parameter is not marked as nullable and is required for the method to function properly, you should validate that it's not null before proceeding to prevent potential NullReferenceExceptions. dotnet/src/webdriver/BiDi/Modules/Network/NetworkModule.HighLevel.cs [27-34] public async Task<Intercept> InterceptRequestAsync(Func<BeforeRequestSentEventArgs, Task> handler, InterceptRequestOptions? options = null) { + ArgumentNullException.ThrowIfNull(handler, nameof(handler)); + var intercept = await AddInterceptAsync([InterceptPhase.BeforeRequestSent], options).ConfigureAwait(false); await intercept.OnBeforeRequestSentAsync(handler).ConfigureAwait(false); return intercept; } Suggestion importance[1-10]: 6	Low

nvborisenko · 2025-04-09T20:30:27Z

This is the first attempt to split "extensions" and "low-level".

dotnet/src/webdriver/BiDi/Modules/Network/NetworkModule.HighLevel.cs

[dotnet] [bidi] Combine network interception to apply rules

02ecaed

selenium-ci added the C-dotnet .NET Bindings label Apr 9, 2025

qodo-code-review bot added the Review effort 2/5 label Apr 9, 2025

nvborisenko marked this pull request as draft April 10, 2025 09:03

nvborisenko added 3 commits April 10, 2025 20:03

Split by intercept phases

4babd34

Stateless converter

34377ba

And from context

ed35158

nvborisenko marked this pull request as ready for review April 11, 2025 07:21

nvborisenko requested a review from RenderMichael April 11, 2025 07:21

qodo-code-review bot added Review effort 3/5 and removed Review effort 2/5 labels Apr 11, 2025

nvborisenko added 2 commits April 11, 2025 10:21

Merge branch 'trunk' into bidi-intercept-highlevel

0eb6194

Merge branch 'trunk' into bidi-intercept-highlevel

b5a5811

nvborisenko changed the title ~~[dotnet] [bidi] Combine network interception to apply rules~~ [dotnet] [bidi] Combine network interception to apply rules (breaking change) Apr 11, 2025

nvborisenko commented Apr 11, 2025

View reviewed changes

dotnet/src/webdriver/BiDi/Modules/Network/NetworkModule.HighLevel.cs Outdated Show resolved Hide resolved

nvborisenko commented Apr 11, 2025

View reviewed changes

dotnet/src/webdriver/BiDi/Modules/Network/NetworkModule.HighLevel.cs Outdated Show resolved Hide resolved

Just CoontinueAsync in intercepted entity

f43836a

nvborisenko merged commit 12a1593 into SeleniumHQ:trunk Apr 11, 2025
10 checks passed

nvborisenko deleted the bidi-intercept-highlevel branch April 11, 2025 19:52

garrettgregor mentioned this pull request May 3, 2025

build(deps-dev): bump selenium-webdriver from 4.31.0 to 4.32.0 garrettgregor/quote-editor#45

Merged

This was referenced Sep 12, 2025

Bump the functionaltests group with 8 updates israurreacarballo/DORA#196

Closed

Bump coverlet.collector and 5 others israurreacarballo/DORA#201

Closed

Bump the selenium group with 2 updates 7474/SRC#677

Merged

This was referenced Sep 19, 2025

Bump coverlet.collector and 5 others israurreacarballo/DORA#217

Closed

Bump the functionaltests group with 9 updates israurreacarballo/DORA#225

Closed

Bump coverlet.collector and 5 others israurreacarballo/DORA#228

Closed

dependabot bot mentioned this pull request Oct 1, 2025

Bump Selenium.Support and 2 others rajbos/github-azure-devops-marketplace-extension-news#275

Closed

This was referenced Oct 1, 2025

Bump coverlet.collector and 5 others israurreacarballo/DORA#230

Closed

Bump Selenium.Support and Selenium.WebDriver rajbos/github-azure-devops-marketplace-extension-news#277

Closed

dependabot bot mentioned this pull request Oct 24, 2025

Bump Selenium.WebDriver from 4.7.0 to 4.37.0 javiertuya/selema#945

Closed

This was referenced Feb 16, 2026

⬆️ Bump Selenium.WebDriver from 4.27.0 to 4.40.0 percy/percy-selenium-dotnet#393

Closed

⬆️ Bump Selenium.WebDriver and System.Text.Json percy/percy-selenium-dotnet#394

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[dotnet] [bidi] Combine network interception to apply rules (breaking change)#15603

[dotnet] [bidi] Combine network interception to apply rules (breaking change)#15603
nvborisenko merged 7 commits intoSeleniumHQ:trunkfrom
nvborisenko:bidi-intercept-highlevel

nvborisenko commented Apr 9, 2025 •

edited

Loading

Uh oh!

qodo-code-review bot commented Apr 9, 2025 •

edited

Loading

Uh oh!

qodo-code-review bot commented Apr 9, 2025 •

edited

Loading

Uh oh!

nvborisenko commented Apr 9, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

nvborisenko commented Apr 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

User description

💥 What does this PR do?

🔧 Implementation Notes

💡 Additional Considerations

🔄 Types of changes

PR Type

Description

Changes walkthrough 📝

Uh oh!

qodo-code-review bot commented Apr 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Reviewer Guide 🔍

(Review updated until commit ed35158)

Uh oh!

qodo-code-review bot commented Apr 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Code Suggestions ✨

Previous suggestions

Uh oh!

nvborisenko commented Apr 9, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

nvborisenko commented Apr 9, 2025 •

edited

Loading

qodo-code-review bot commented Apr 9, 2025 •

edited

Loading

(Review updated until commit `ed35158`)

qodo-code-review bot commented Apr 9, 2025 •

edited

Loading