Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[py] Better error for downloads on local webdrivers#15756

Merged
cgoldberg merged 5 commits intoSeleniumHQ:trunkfrom
cgoldberg:py-downloads-not-implemented
May 22, 2025
Merged

[py] Better error for downloads on local webdrivers#15756
cgoldberg merged 5 commits intoSeleniumHQ:trunkfrom
cgoldberg:py-downloads-not-implemented

Conversation

@cgoldberg
Copy link
Member

@cgoldberg cgoldberg commented May 20, 2025 •
edited by qodo-code-review bot
Loading

User description

🔗 Related Issues

Fixes #15753

💥 What does this PR do?

This PR raises NotImplementedError when trying to call get_downloadable_files() or download_file() on any local WebDriver. These methods are only available on the parent WebDriver class (AKA Remote).

This just makes the error thrown a little less cryptic for the user.

🔄 Types of changes

  • Bug fix

PR Type

Bug fix

Description

  • Raise NotImplementedError for download methods on local drivers

  • Improve error clarity for unsupported download operations

  • Affects Chromium, Firefox, IE, Safari, WebKitGTK, and WPEWebKit drivers

Changes walkthrough 📝

Relevant files
Bug fix
webdriver.py
Add NotImplementedError for download methods in Chromium driver

py/selenium/webdriver/chromium/webdriver.py

  • Added download_file and get_downloadable_files methods
  • Both methods now raise NotImplementedError
    		• +6/-0     
    webdriver.py
    Add NotImplementedError for download methods in Firefox driver

    py/selenium/webdriver/firefox/webdriver.py

  • Added download_file and get_downloadable_files methods
  • Both methods now raise NotImplementedError
    		• +6/-0     
    webdriver.py
    Add NotImplementedError for download methods in IE driver

    py/selenium/webdriver/ie/webdriver.py

  • Added download_file and get_downloadable_files methods
  • Both methods now raise NotImplementedError
    		• +6/-0     
    webdriver.py
    Add NotImplementedError for download methods in Safari driver

    py/selenium/webdriver/safari/webdriver.py

  • Added download_file and get_downloadable_files methods
  • Both methods now raise NotImplementedError
    		• +6/-0     
    webdriver.py
    Add NotImplementedError for download methods in WebKitGTK driver

    py/selenium/webdriver/webkitgtk/webdriver.py

  • Added download_file and get_downloadable_files methods
  • Both methods now raise NotImplementedError
    		• +6/-0     
    webdriver.py
    Add NotImplementedError for download methods in WPEWebKit driver

    py/selenium/webdriver/wpewebkit/webdriver.py

  • Added download_file and get_downloadable_files methods
  • Both methods now raise NotImplementedError
    		• +6/-0     
    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
    •

    @selenium-ci selenium-ci added the C-py Python Bindings label May 20, 2025
    @qodo-code-review
    Copy link
    Contributor

    qodo-code-review bot commented May 20, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Error Message

    The NotImplementedError is raised without a descriptive message explaining why these methods are not available on local WebDrivers or suggesting alternatives.

     
    raise NotImplementedError

    @qodo-code-review
    Copy link
    Contributor

    qodo-code-review bot commented May 20, 2025 •
    edited
    Loading

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    General
    Add descriptive error messages

    Add descriptive error messages to the NotImplementedError exceptions to inform
    users that these methods are not supported for local webdrivers. This provides
    clearer guidance on why the operation failed.

    py/selenium/webdriver/chromium/webdriver.py [226-230]

     def download_file(self, *args, **kwargs):
-    raise NotImplementedError
+    raise NotImplementedError("The download_file method is not supported for local webdrivers")
 
 def get_downloadable_files(self, *args, **kwargs):
-    raise NotImplementedError
+    raise NotImplementedError("The get_downloadable_files method is not supported for local webdrivers")
    • Apply / Chat
    Suggestion importance[1-10]: 5

    __

    Why: Adding descriptive error messages to NotImplementedError improves developer experience by clarifying why the methods are not available, but it does not affect core functionality or correctness.

    		Low
    • Update

    @cgoldberg cgoldberg merged commit 4fc2582 into SeleniumHQ:trunk May 22, 2025
    16 checks passed
    @cgoldberg cgoldberg deleted the py-downloads-not-implemented branch May 22, 2025 17:44
    This was referenced Sep 12, 2025
    Closed
    Closed
    Merged
    This was referenced Sep 19, 2025
    Closed
    Closed
    Closed
    This was referenced Oct 1, 2025
    Closed
    Closed
    Closed
    @dependabot dependabot bot mentioned this pull request Oct 24, 2025
    Closed
    This was referenced Dec 21, 2025
    Open
    Closed
    Closed
    Closed
    This was referenced Jan 19, 2026
    Closed
    Closed
    Closed
    Merged
    @dependabot dependabot bot mentioned this pull request Feb 16, 2026
    Closed
    @dependabot dependabot bot mentioned this pull request Feb 16, 2026
    Closed
    This was referenced Feb 23, 2026
    Closed
    Open
    Open
    Open
    Open
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    No reviews

    Assignees

    No one assigned

    Labels

    C-py Python Bindings Review effort 1/5

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    [🐛 Bug]: [py] Downloading files doesn't work for local drivers

    2 participants

    @cgoldberg @selenium-ci