Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[py][tests]: check for .txt file in remote download test#15758

Merged
diemol merged 2 commits intoSeleniumHQ:trunkfrom
navin772:fix-remote-download-tests
May 20, 2025
Merged

[py][tests]: check for .txt file in remote download test#15758
diemol merged 2 commits intoSeleniumHQ:trunkfrom
navin772:fix-remote-download-tests

Conversation

@navin772
Copy link
Member

@navin772 navin772 commented May 20, 2025 •
edited by qodo-code-review bot
Loading

User description

🔗 Related Issues

💥 What does this PR do?

Fixes the failing remote download tests in the CI

🔧 Implementation Notes

Currently the assertion doesn't checks if it is asserting against a txt file or the jpg file. This change asserts against the .txt file only which contains the Hello, World! content.

💡 Additional Considerations

🔄 Types of changes

  • Cleanup (formatting, renaming)

PR Type

Tests

Description

  • Refines remote download test to target .txt files

  • Ensures test asserts only on .txt file content

  • Improves reliability of download file test

Changes walkthrough 📝

Relevant files
Tests
remote_downloads_tests.py
Update remote download test to target .txt files                 

py/test/selenium/webdriver/remote/remote_downloads_tests.py

  • Modifies test to specifically select .txt files for download
  • Adds assertion to ensure a .txt file is present in downloadable files
  • Updates file reading and assertion to use the .txt file
    		• +7/-3     
    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
    •

    @selenium-ci selenium-ci added the C-py Python Bindings label May 20, 2025
    @navin772 navin772 marked this pull request as ready for review May 20, 2025 11:50
    @qodo-code-review
    Copy link
    Contributor

    qodo-code-review bot commented May 20, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    🎫 Ticket compliance analysis ❌

    1234 - Not compliant

    Non-compliant requirements:

    • Fix issue where Selenium 2.48 doesn't trigger JavaScript in link's href on click()
    • Ensure JavaScript alerts are triggered when clicking links with JavaScript in href attributes
    • Make behavior consistent with previous version (2.47.1)
    • Fix specifically for Firefox 42.0

    5678 - Not compliant

    Non-compliant requirements:

    • Fix "ConnectFailure (Connection refused)" error when instantiating ChromeDriver
    • Address issue where subsequent ChromeDriver instantiations fail after first successful one
    • Fix specifically for Chrome 65.0.3325.181 with ChromeDriver 2.35 on Ubuntu 16.04.4

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 PR contains tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    @qodo-code-review
    Copy link
    Contributor

    qodo-code-review bot commented May 20, 2025 •
    edited
    Loading

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    General
    Handle file encoding safely

    Open the file in binary mode first to handle potential encoding issues. Text
    files downloaded from remote sources may have different encodings or line
    endings that could cause reading errors.

    py/test/selenium/webdriver/remote/remote_downloads_tests.py [47-48]

    -with open(target_file, "r") as file:
-    assert "Hello, World!" in file.read()
+with open(target_file, "rb") as file:
+    content = file.read().decode('utf-8', errors='replace')
+    assert "Hello, World!" in content
    • Apply / Chat
    Suggestion importance[1-10]: 7

    __

    Why: Opening the file in binary mode and decoding explicitly can prevent encoding-related errors when reading files from external sources, improving test robustness. However, since the test likely controls the file content and encoding, the impact is moderate rather than critical.

    		Medium
    Learned
    best practice
    Validate collection before processing

    The code correctly checks if text_file_name is None, but it's better to validate
    downloadable_files first to ensure it's not empty before attempting to find a
    .txt file. This prevents potential issues if get_downloadable_files() returns an
    empty list.

    py/test/selenium/webdriver/remote/remote_downloads_tests.py [40-41]

    +downloadable_files = driver.get_downloadable_files()
+assert downloadable_files, "No downloadable files found"
 text_file_name = next((file for file in downloadable_files if file.endswith(".txt")), None)
 assert text_file_name is not None, "Could not find a .txt file in downloadable files"
    • Apply / Chat
    Suggestion importance[1-10]: 6

    __

    Why:
    Relevant best practice - Add null checks for parameters and properties before using them to prevent exceptions

    		Low
    • Update

    @navin772
    Copy link
    Member Author

    navin772 commented May 20, 2025

    The remote_downloads_tests.py is failing on all PRs, this PR fixes the test.

    @sandeepsuryaprasad
    Copy link
    Contributor

    sandeepsuryaprasad commented May 20, 2025

    @navin772 thanks for this PR.. this was much needed fix..

    @navin772 navin772 requested a review from cgoldberg May 20, 2025 11:58
    diemol
    diemol approved these changes May 20, 2025
    View reviewed changes
    Copy link
    Member

    @diemol diemol left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Thanks for the fix! I wonder why it started failing.

    I'd love to see a review from @cgoldberg as well.

    @navin772
    Copy link
    Member Author

    navin772 commented May 20, 2025

    @diemol I think the get_downloadable_files() function's return order might have changed so we cannot pick the 0th index file. Might be a change from the browser's end.

    cgoldberg
    cgoldberg approved these changes May 20, 2025
    View reviewed changes
    Copy link
    Member

    @cgoldberg cgoldberg left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM .. thanks for fixing this

    @diemol diemol merged commit 0e1ac19 into SeleniumHQ:trunk May 20, 2025
    16 checks passed
    @sandeepsuryaprasad sandeepsuryaprasad mentioned this pull request May 20, 2025
    Merged
    8 tasks
    @navin772 navin772 deleted the fix-remote-download-tests branch May 20, 2025 16:05
    This was referenced Sep 12, 2025
    Closed
    Closed
    Merged
    This was referenced Sep 19, 2025
    Closed
    Closed
    Closed
    This was referenced Oct 1, 2025
    Closed
    Closed
    Closed
    @dependabot dependabot bot mentioned this pull request Oct 24, 2025
    Closed
    This was referenced Dec 21, 2025
    Open
    Closed
    Closed
    Closed
    This was referenced Jan 19, 2026
    Closed
    Closed
    Closed
    Merged
    This was referenced Feb 16, 2026
    Closed
    Closed
    This was referenced Feb 23, 2026
    Closed
    Open
    Open
    Open
    Open
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @cgoldberg cgoldberg cgoldberg approved these changes

    @diemol diemol diemol approved these changes

    Assignees

    No one assigned

    Labels

    C-py Python Bindings Review effort 1/5

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    5 participants

    @navin772 @sandeepsuryaprasad @cgoldberg @diemol @selenium-ci