Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[dotnet] [bidi] Add UnhandledPromptBehavior option to create User Context #16034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2025
Merged

[dotnet] [bidi] Add UnhandledPromptBehavior option to create User Context #16034

merged 1 commit into from
Jul 9, 2025

Conversation

nvborisenko
Copy link
Member

@nvborisenko nvborisenko commented Jul 9, 2025 •
edited by qodo-merge-pro bot
Loading

User description

Spec: https://w3c.github.io/webdriver-bidi/#command-browser-createUserContext

🔧 Implementation Notes

Easy change.

💡 Additional Considerations

🔄 Types of changes

  • New feature (non-breaking change which adds functionality and tests!)

PR Type

Enhancement

Description

  • Add UnhandledPromptBehavior option to BiDi CreateUserContext command

  • Update command parameters and options to support prompt handling configuration

Changes diagram

flowchart LR
  A["CreateUserContextOptions"] --> B["UnhandledPromptBehavior property"]
  B --> C["CreateUserContextCommandParameters"]
  C --> D["BrowserModule.CreateUserContextAsync"]
Loading

Changes walkthrough 📝

Relevant files
Enhancement
BrowserModule.cs
Pass UnhandledPromptBehavior to command parameters             

dotnet/src/webdriver/BiDi/Browser/BrowserModule.cs

  • Update CreateUserContextAsync method to pass UnhandledPromptBehavior
    parameter
  • Modify CreateUserContextCommandParameters constructor call
    		• +1/-1     
    CreateUserContextCommand.cs
    Add UnhandledPromptBehavior support to command structure 

    dotnet/src/webdriver/BiDi/Browser/CreateUserContextCommand.cs

  • Add UnhandledPromptBehavior parameter to
    CreateUserContextCommandParameters record
  • Add UnhandledPromptBehavior property to CreateUserContextOptions class
    		• +3/-1     
    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
    •

    @selenium-ci selenium-ci added the C-dotnet .NET Bindings label Jul 9, 2025
    @qodo-merge-pro Qodo Merge Pro
    Copy link
    Contributor

    qodo-merge-pro bot commented Jul 9, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Missing Tests

    The new UnhandledPromptBehavior parameter is added without corresponding unit tests to verify the parameter is properly passed through the command chain and serialized correctly.

     
    internal sealed record CreateUserContextCommandParameters(bool? AcceptInsecureCerts, Session.ProxyConfiguration? Proxy, Session.UserPromptHandler? UnhandledPromptBehavior) : CommandParameters;

public sealed class CreateUserContextOptions : CommandOptions
{
    public bool? AcceptInsecureCerts { get; set; }

    public Session.ProxyConfiguration? Proxy { get; set; }

    public Session.UserPromptHandler? UnhandledPromptBehavior { get; set; }

    @qodo-merge-pro Qodo Merge Pro
    Copy link
    Contributor

    qodo-merge-pro bot commented Jul 9, 2025

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @nvborisenko nvborisenko merged commit 929f343 into SeleniumHQ:trunk Jul 9, 2025
    13 checks passed
    @nvborisenko nvborisenko deleted the bidi-uc-prompt branch July 9, 2025 21:28
    This was referenced Sep 12, 2025
    Open
    Open
    Open
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers
    No reviews
    Assignees
    No one assigned
    Labels
    C-dotnet .NET Bindings Review effort 2/5
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    2 participants
    @nvborisenko @selenium-ci