Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[py] Use daemon threads for WebSocket connections #16298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from
Open

[py] Use daemon threads for WebSocket connections #16298

wants to merge 4 commits into from
+2 −2

Conversation

cgoldberg
Copy link
Contributor

@cgoldberg cgoldberg commented Sep 8, 2025 •
edited by qodo-merge-pro bot
Loading

User description

🔗 Related Issues

Fixes #16294

💥 What does this PR do?

This PR makes the threads used for WebSockets into "daemon threads". This probably doesn't make much practical difference, but it will alleviate an annoying condition where you just want to exit a program, but for some reason the WebSocket connection or callback is hanging.

With the daemon flag, all threads will be abruptly killed on interpreter shutdown.

See: #16294 for more information

🔄 Types of changes

  • Bug fix (backwards compatible)

PR Type

Bug fix

Description

  • Convert WebSocket threads to daemon threads for proper shutdown

  • Prevents hanging threads from blocking interpreter exit

  • Applies to both main WebSocket connection and callback threads

Diagram Walkthrough

flowchart LR
  A["WebSocket Connection"] --> B["Main Thread"]
  A --> C["Callback Threads"]
  B --> D["Daemon Thread"]
  C --> E["Daemon Threads"]
  D --> F["Clean Shutdown"]
  E --> F
Loading

File Walkthrough
Relevant files
Bug fix
websocket_connection.py
Convert WebSocket threads to daemon threads                           

py/selenium/webdriver/remote/websocket_connection.py

  • Added daemon=True parameter to main WebSocket thread creation
  • Added daemon=True parameter to callback thread creation
  • Ensures threads don't prevent interpreter shutdown
 +2/-2     

@selenium-ci selenium-ci added the C-py Python Bindings label Sep 8, 2025
@qodo-merge-pro Qodo Merge Pro
Copy link
Contributor

qodo-merge-pro bot commented Sep 8, 2025

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Behavior Change

Daemonizing the main WebSocket thread means it may terminate abruptly during interpreter shutdown, potentially dropping in-flight messages or leaving cleanup callbacks unexecuted. Confirm this is acceptable for all consumers and that shutdown paths do not rely on graceful thread joins.

 
self._ws_thread = Thread(target=run_socket, daemon=True)
self._ws_thread.start()
Callback Side Effects

Running callbacks on daemon threads can interrupt user code mid-execution at shutdown, which may cause partial state updates or resource leaks. Validate that callbacks are idempotent, short-lived, and do not require guaranteed completion or critical cleanup.

 
params = message["params"]
for callback in self.callbacks.get(message["method"], []):
    Thread(target=callback, args=(params,), daemon=True).start()

@qodo-merge-pro Qodo Merge Pro
Copy link
Contributor

qodo-merge-pro bot commented Sep 8, 2025 •
edited
Loading

PR Code Suggestions ✨

No code suggestions found for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C-py Python Bindings Review effort 2/5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🚀 Feature]: [py] Use daemonic threads in WebSocket connections
2 participants
@cgoldberg @selenium-ci