Codestin Search App

nvborisenko · 2025-10-04T17:03:03Z

User description

https://w3c.github.io/webdriver-bidi/#module-emulation

💥 What does this PR do?

Implements entire emulation module.

🔄 Types of changes

New feature (non-breaking change which adds functionality and tests!)

PR Type

Enhancement

Description

Implements complete WebDriver BiDi emulation module
Adds 7 emulation commands for browser behavior control
Includes timezone, user agent, locale, and geolocation overrides
Provides screen orientation and scripting control features

Diagram Walkthrough

flowchart LR
  BiDi["BiDi Main Class"] --> EmulationModule["Emulation Module"]
  EmulationModule --> Commands["7 Override Commands"]
  Commands --> Timezone["Timezone Override"]
  Commands --> UserAgent["User Agent Override"]
  Commands --> Locale["Locale Override"]
  Commands --> Colors["Forced Colors Theme"]
  Commands --> Scripting["Scripting Control"]
  Commands --> Orientation["Screen Orientation"]
  Commands --> Geolocation["Geolocation Override"]
  Broker["Communication Broker"] --> Serialization["JSON Serialization"]
  Serialization --> Converter["Screen Orientation Converter"]

File Walkthrough

Relevant files

Enhancement

10 files

BiDi.cs `Add emulation module property and initialization`	+14/-0
ScreenOrientationTypeConverter.cs `Custom JSON converter for screen orientation types`	+55/-0
EmulationModule.cs `Main emulation module with all override methods`	+92/-0
SetForcedColorsModeThemeOverrideCommand.cs `Command for forced colors mode theme override`	+42/-0
SetGeolocationOverrideCommand.cs `Command for geolocation coordinates and position error override`	+61/-0
SetLocaleOverrideCommand.cs `Command for locale override functionality`	+36/-0
SetScreenOrientationOverrideCommand.cs `Command for screen orientation override with enums`	+52/-0
SetScriptingEnabledCommand.cs `Command for enabling or disabling scripting`	+36/-0
SetTimezoneOverrideCommand.cs `Command for timezone override functionality`	+36/-0
SetUserAgentOverrideCommand.cs `Command for user agent string override`	+36/-0

Configuration changes

2 files

Broker.cs `Register screen orientation type converter`	+1/-0
BiDiJsonSerializerContext.cs `Add JSON serialization for emulation commands`	+7/-0

Tests

1 files

EmulationTest.cs `Unit tests for all emulation module commands`	+76/-0

qodo-code-review · 2025-10-04T17:03:37Z

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢	No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
⚪	🎫 No ticket provided Create ticket/issue
Codebase Duplication Compliance
⚪	Codebase context is not defined Follow the guide to enable codebase context checks.
Custom Compliance
⚪	No custom compliance provided Follow the guide to enable custom compliance check.
Update

Compliance status legend

🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

nvborisenko

Review tests, ignore some browsers if needed.

qodo-code-review · 2025-10-04T17:04:50Z

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
High-level	Consolidate duplicated command option classes To reduce code duplication, create a reusable base class for the multiple new command `Options` classes that share identical properties for targeting browsing contexts and user contexts. Examples: dotnet/src/webdriver/BiDi/Emulation/SetTimezoneOverrideCommand.cs [31-36] public sealed class SetTimezoneOverrideOptions : CommandOptions { public IEnumerable<BrowsingContext.BrowsingContext>? Contexts { get; set; } public IEnumerable<Browser.UserContext>? UserContexts { get; set; } } dotnet/src/webdriver/BiDi/Emulation/SetLocaleOverrideCommand.cs [31-36] public sealed class SetLocaleOverrideOptions : CommandOptions { public IEnumerable<BrowsingContext.BrowsingContext>? Contexts { get; set; } public IEnumerable<Browser.UserContext>? UserContexts { get; set; } } Solution Walkthrough: Before: // In SetTimezoneOverrideCommand.cs public sealed class SetTimezoneOverrideOptions : CommandOptions { public IEnumerable<BrowsingContext.BrowsingContext>? Contexts { get; set; } public IEnumerable<Browser.UserContext>? UserContexts { get; set; } } // In SetLocaleOverrideCommand.cs public sealed class SetLocaleOverrideOptions : CommandOptions { public IEnumerable<BrowsingContext.BrowsingContext>? Contexts { get; set; } public IEnumerable<Browser.UserContext>? UserContexts { get; set; } } // ... and 4 other identical classes After: // In a new shared file or a relevant existing one public class ContextOptions : CommandOptions { public IEnumerable<BrowsingContext.BrowsingContext>? Contexts { get; set; } public IEnumerable<Browser.UserContext>? UserContexts { get; set; } } // In SetTimezoneOverrideCommand.cs public sealed class SetTimezoneOverrideOptions : ContextOptions { } // In SetLocaleOverrideCommand.cs public sealed class SetLocaleOverrideOptions : ContextOptions { } // ... and so on for other option classes Suggestion importance[1-10]: 7 __ Why: The suggestion correctly identifies significant code duplication across multiple new `Options` classes and proposes a valid solution that improves maintainability by using a shared base class.	Medium
Possible issue	Ensure correct enum JSON serialization To ensure `ForcedColorsModeTheme` enum values serialize to lowercase strings as per the WebDriver BiDi specification, add the `[JsonStringEnumConverter]` attribute to the enum definition. dotnet/src/webdriver/BiDi/Emulation/SetForcedColorsModeThemeOverrideCommand.cs [38-42] +[JsonStringEnumConverter] public enum ForcedColorsModeTheme { Light, Dark } Apply / Chat Suggestion importance[1-10]: 7 __ Why: The suggestion correctly identifies that the `ForcedColorsModeTheme` enum will be serialized incorrectly as an integer, but the proposed fix using `[JsonStringEnumConverter]` is incomplete as it would serialize to "Light" and "Dark" instead of the required "light" and "dark".	Medium
Update

nvborisenko added 8 commits October 4, 2025 17:37

Emulation placeholder

62264e3

SetTimezone

1c957e6

SetUserAgent

c97e8fc

SetLocale

de30f4b

SetForcedColorsModeTheme

1af3dcb

SetScriptingEnabled

a470cbc

SetScreenOrientation

c811212

SetGeolocation

1e75ae9

selenium-ci added the C-dotnet .NET Bindings label Oct 4, 2025

qodo-code-review bot added the Review effort 3/5 label Oct 4, 2025

nvborisenko commented Oct 4, 2025

View reviewed changes

nvborisenko added 4 commits October 4, 2025 20:22

Fix format

4f253fa

Ignoring not supported browsers

0d810ce

Stylish

cd15fa1

Ignore CanSetScriptingEnabled for Edge

d7a7b50

nvborisenko merged commit 565459e into SeleniumHQ:trunk Oct 4, 2025
10 checks passed

nvborisenko deleted the bidi-emulation-module branch October 4, 2025 19:27

dependabot bot mentioned this pull request Dec 22, 2025

chore(deps): nuget update: Bump Selenium.WebDriver from 4.34.0 to 4.39.0 BySuspect/AutoPixAiCreditClaimer#40

Closed

dependabot bot mentioned this pull request Jan 5, 2026

Bump Selenium.WebDriver from 4.36.0 to 4.39.0 Dor-bl/dotnet-client#173

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[dotnet] [bidi] Emulation module#16380

[dotnet] [bidi] Emulation module#16380
nvborisenko merged 12 commits intoSeleniumHQ:trunkfrom
nvborisenko:bidi-emulation-module

nvborisenko commented Oct 4, 2025 •

edited by qodo-code-review bot

Loading

Uh oh!

qodo-code-review bot commented Oct 4, 2025 •

edited

Loading

Uh oh!

nvborisenko left a comment

Uh oh!

qodo-code-review bot commented Oct 4, 2025 •

edited

Loading

Examples:

Solution Walkthrough:

Before:

After:

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

nvborisenko commented Oct 4, 2025 • edited by qodo-code-review bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

User description

💥 What does this PR do?

🔄 Types of changes

PR Type

Description

Diagram Walkthrough

File Walkthrough

Uh oh!

qodo-code-review bot commented Oct 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Compliance Guide 🔍

Uh oh!

nvborisenko left a comment

Choose a reason for hiding this comment

Uh oh!

qodo-code-review bot commented Oct 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Code Suggestions ✨

Examples:

Solution Walkthrough:

Before:

After:

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

nvborisenko commented Oct 4, 2025 •

edited by qodo-code-review bot

Loading

qodo-code-review bot commented Oct 4, 2025 •

edited

Loading

qodo-code-review bot commented Oct 4, 2025 •

edited

Loading