Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[dotnet] Replace lazy caching mechanism in BiDi's constructor with simple initialization#16399

Merged
nvborisenko merged 2 commits intoSeleniumHQ:trunkfrom
RenderMichael:bidi-ctor
Oct 9, 2025
Merged

[dotnet] Replace lazy caching mechanism in BiDi's constructor with simple initialization#16399
nvborisenko merged 2 commits intoSeleniumHQ:trunkfrom
RenderMichael:bidi-ctor

Conversation

@RenderMichael
Copy link
Contributor

@RenderMichael RenderMichael commented Oct 8, 2025 •
edited by qodo-code-review bot
Loading

User description

🔄 Types of changes

  • Cleanup (formatting, renaming)

PR Type

Other

Description

  • Replace lazy caching mechanism with direct initialization

  • Remove ConcurrentDictionary and AsModule method

  • Convert module properties to auto-properties

  • Reorganize using statements for better readability

Diagram Walkthrough

flowchart LR
  A["Lazy Loading"] --> B["Direct Initialization"]
  C["ConcurrentDictionary"] --> D["Auto-Properties"]
  E["AsModule Method"] --> F["Constructor Assignment"]
Loading

File Walkthrough
Relevant files
Enhancement
BiDi.cs
Simplify module initialization pattern                                     

dotnet/src/webdriver/BiDi/BiDi.cs

  • Removed ConcurrentDictionary-based lazy loading mechanism
  • Replaced AsModule method with direct module initialization in
    constructor
  • Converted module properties from methods to auto-properties
  • Reorganized using statements alphabetically
 +23/-21 

@selenium-ci selenium-ci added the C-dotnet .NET Bindings label Oct 8, 2025
@qodo-code-review
Copy link
Contributor

qodo-code-review bot commented Oct 8, 2025 •
edited
Loading

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
⚪
🎫 No ticket provided
  • Create ticket/issue
Codebase Duplication Compliance
⚪
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
⚪
No custom compliance provided

Follow the guide to enable custom compliance check.

  • Update
Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

@qodo-code-review
Copy link
Contributor

qodo-code-review bot commented Oct 8, 2025 •
edited
Loading

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
General
Refactor module creation into helper

Refactor the repetitive module creation logic into a private helper method to
centralize the logic and improve maintainability.

dotnet/src/webdriver/BiDi/BiDi.cs [68-77]

-SessionModule = Module.Create<Session.SessionModule>(this, _broker, _jsonOptions, _jsonContext);
-BrowsingContext = Module.Create<BrowsingContext.BrowsingContextModule>(this, _broker, _jsonOptions, _jsonContext);
-Browser = Module.Create<Browser.BrowserModule>(this, _broker, _jsonOptions, _jsonContext);
-Network = Module.Create<Network.NetworkModule>(this, _broker, _jsonOptions, _jsonContext);
-InputModule = Module.Create<Input.InputModule>(this, _broker, _jsonOptions, _jsonContext);
-Script = Module.Create<Script.ScriptModule>(this, _broker, _jsonOptions, _jsonContext);
-Log = Module.Create<Log.LogModule>(this, _broker, _jsonOptions, _jsonContext);
-Storage = Module.Create<Storage.StorageModule>(this, _broker, _jsonOptions, _jsonContext);
-WebExtension = Module.Create<WebExtension.WebExtensionModule>(this, _broker, _jsonOptions, _jsonContext);
-Emulation = Module.Create<Emulation.EmulationModule>(this, _broker, _jsonOptions, _jsonContext);
+SessionModule = CreateModule<Session.SessionModule>();
+BrowsingContext = CreateModule<BrowsingContext.BrowsingContextModule>();
+Browser = CreateModule<Browser.BrowserModule>();
+Network = CreateModule<Network.NetworkModule>();
+InputModule = CreateModule<Input.InputModule>();
+Script = CreateModule<Script.ScriptModule>();
+Log = CreateModule<Log.LogModule>();
+Storage = CreateModule<Storage.StorageModule>();
+WebExtension = CreateModule<WebExtension.WebExtensionModule>();
+Emulation = CreateModule<Emulation.EmulationModule>();
  • Apply / Chat
Suggestion importance[1-10]: 6

__

Why: The suggestion correctly identifies repetitive code introduced in the constructor and proposes a valid refactoring into a helper method, which improves maintainability and readability.

Low
  • Update

nvborisenko
nvborisenko reviewed Oct 8, 2025
View reviewed changes
nvborisenko
nvborisenko reviewed Oct 8, 2025
View reviewed changes
@nvborisenko nvborisenko merged commit 2109f38 into SeleniumHQ:trunk Oct 9, 2025
10 checks passed
This was referenced Oct 19, 2025
Merged
Closed
Merged
Merged
Closed
Closed
Closed
Merged
Merged
Closed
Closed
Merged
Merged
Closed
Closed
Merged
Closed
Merged
Closed
This was referenced Dec 15, 2025
Closed
Closed
Merged
Open
Closed
Closed
Closed
@dependabot dependabot bot mentioned this pull request Dec 22, 2025
Closed
@dependabot dependabot bot mentioned this pull request Jan 5, 2026
Closed
This was referenced Jan 19, 2026
Closed
Closed
Closed
Closed
Open
Closed
Closed
Merged
This was referenced Feb 11, 2026
Closed
Closed
Closed
This was referenced Feb 20, 2026
Merged
Open
Closed
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nvborisenko nvborisenko nvborisenko approved these changes

Assignees

No one assigned

Labels

C-dotnet .NET Bindings Review effort 2/5

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RenderMichael @nvborisenko @selenium-ci