Description: Marking the field and accessor scriptId as nullable introduces potential null dereference
risks for existing code paths that assumed non-null, which could cause NPEs or logic
errors if not audited where getScriptId() is consumed.
UnpinnedScriptKey.java [67-73]

public void setScriptId(@Nullable String id) {
  this.scriptId = id;
}

public @Nullable String getScriptId() {
  return this.scriptId;
}

Follow the guide to enable codebase context checks.

Follow the guide to enable custom compliance check.

Fix the equals method in UnpinnedScriptKey by removing the super.equals(o) call
and comparing the script and scriptId fields for equality.

java/src/org/openqa/selenium/UnpinnedScriptKey.java [105-110]

-if (!super.equals(o)) {
-  return false;
-}
+UnpinnedScriptKey that = (UnpinnedScriptKey) o;
+return Objects.equals(this.script, that.script) && Objects.equals(this.scriptId, that.scriptId);
 
-UnpinnedScriptKey that = (UnpinnedScriptKey) o;
-return Objects.equals(this.script, that.script);
-

[To ensure code accuracy, apply this suggestion manually]

Update the hashCode method in UnpinnedScriptKey to be consistent with the equals
method by using the script and scriptId fields, and removing super.hashCode().

java/src/org/openqa/selenium/UnpinnedScriptKey.java [113-116]

 @Override
 public int hashCode() {
-  return Objects.hash(super.hashCode(), script);
+  return Objects.hash(script, scriptId);
 }

[To ensure code accuracy, apply this suggestion manually]

Add explicit null-state validation or documentation to clarify when scriptId may
be null and guard access sites; at minimum, document the nullability contract
here.

java/src/org/openqa/selenium/UnpinnedScriptKey.java [35-73]

+/**
+ * May be null until the script is pinned; once set, may be cleared on unpin.
+ */
 private @Nullable String scriptId;
 
+/**
+ * Sets the script id; pass null to clear when unpinning.
+ */
 public void setScriptId(@Nullable String id) {
   this.scriptId = id;
 }
 
+/**
+ * Returns the script id if pinned, otherwise null.
+ */
 public @Nullable String getScriptId() {
   return this.scriptId;
 }

• Apply / Chat