Print the filename if set #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you run `ErubiImplementation#validate!` (as described in the readme) and there's a validation error it will print the line number and column but not the filename. You can pass the filename to erubi (like this `BetterHtml::BetterErb::ErubiImplementation.new(data, config: BetterHtml.config, filename:).validate!`) but `ErubiImplementation` doesn't use that information in it's error message. I've updated runtime checks so that if the filename is passed to `ErubiImplementation` it will be used in error messages, which can really help when fixing errors.
272762c to
6b39b6e
Compare
|
I have signed the CLA! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you run
ErubiImplementation#validate!(as described in the readme) and there's a validation error it will print the line number and column but not the filename. You can pass the filename to erubi (like thisBetterHtml::BetterErb::ErubiImplementation.new(data, config: BetterHtml.config, filename:).validate!) butErubiImplementationdoesn't use that information in it's error message.I've updated runtime checks so that if the filename is passed to
ErubiImplementationit will be used in error messages, which can really help when fixing errors.