Use ruby_strdup with xfree #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruby_strdup is like strdup, but using xmalloc which informs Ruby's GC about the allocation (confusingly by including ruby/util.h strdup is defined into ruby_strdup, but let's use ruby_strdup for clarity).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ruby_strdupis likestrdup, but usingxmallocwhich informs Ruby's GC about the allocation (confusingly by includingruby/util.hstrdupis defined intoruby_strdup, but let's useruby_strdupfor clarity). We need to use this because we usexfreefor the message inparser_free.The issue this causes is pretty minimal in regular builds, it will artificially decrease
oldmalloc_increase_bytes, but it's unlikely to be a significant amount. However getting this correct is important so that this extension can be used with debug builds.