Corrected how the railtie gets annotate_rendered_view_with_filenames #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry @rafaelfranca it seems like #122 isn't working for me (not sure why, it worked during development) so I've raised this PR to make the railtie work in a different way. |
1fe745d to
d42129a
Compare
The way we were getting annotate_rendered_view_with_filenames from rails wasn't working. I've changed it to get the config option directly from the rails config, which is hopefully a bit simpler and does not depend on any loading order.
d42129a to
686fa48
Compare
|
We need to understand why it isn't working, because it should. Can you provide a way to reproduce? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way we were getting annotate_rendered_view_with_filenames from rails wasn't working (added in #122). I think this is due to loading order but it's hard to be sure because I can't actually see where rails initialises the value we were using.
I've changed it to get the config option directly from the rails config, which is hopefully a bit simpler and does not depend on any loading order.