Readme .yml config update #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `YAML.unsafe_load` to parse regex values, `load` won't by default
|
I have signed the CLA! |
thejonroberts
commented
Jul 22, 2024
|
@etiennebarrie what do you think of this readme change? Sorry for the ping, this has been up for 2 weeks. |
Co-authored-by: Jon Roberts <[email protected]>
etiennebarrie
approved these changes
Jul 30, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the readme to use
YAML.unsafe_loadto parse regex values,loadwon't by default. I had the same issue as #106 , and this solved it. See this psych discussion.Note: .yml regex values must be in format
!ruby/regexp /\A[a-z0-9\-\:]+\z/to be read as Regexp class. Not specific to this gem, but I can add a note below this if it is helpful.