Fix an error when parsing attribute without quotes and value #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```
/home/earlopain/.rbenv/versions/3.3.4/lib/ruby/gems/3.3.0/gems/parser-3.3.4.2/lib/parser/source/range.rb:39:in `initialize': Parser::Source::Range: end_pos must not be less than begin_pos (ArgumentError)
raise ArgumentError, 'Parser::Source::Range: end_pos must not be less than begin_pos'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
from /home/earlopain/.rbenv/versions/3.3.4/lib/ruby/gems/3.3.0/gems/better_html-2.1.1/lib/better_html/tokenizer/location.rb:23:in `initialize'
from /home/earlopain/.rbenv/versions/3.3.4/lib/ruby/gems/3.3.0/gems/better_html-2.1.1/lib/better_html/parser.rb:214:in `new'
from /home/earlopain/.rbenv/versions/3.3.4/lib/ruby/gems/3.3.0/gems/better_html-2.1.1/lib/better_html/parser.rb:214:in `build_location'
from /home/earlopain/.rbenv/versions/3.3.4/lib/ruby/gems/3.3.0/gems/better_html-2.1.1/lib/better_html/parser.rb:206:in `build_node'
from /home/earlopain/.rbenv/versions/3.3.4/lib/ruby/gems/3.3.0/gems/better_html-2.1.1/lib/better_html/parser.rb:177:in `build_attribute_node'
from /home/earlopain/.rbenv/versions/3.3.4/lib/ruby/gems/3.3.0/gems/better_html-2.1.1/lib/better_html/parser.rb:151:in `build_tag_attributes_node'
from /home/earlopain/.rbenv/versions/3.3.4/lib/ruby/gems/3.3.0/gems/better_html-2.1.1/lib/better_html/parser.rb:133:in `build_tag_node'
from /home/earlopain/.rbenv/versions/3.3.4/lib/ruby/gems/3.3.0/gems/better_html-2.1.1/lib/better_html/parser.rb:79:in `build_document_node'
from /home/earlopain/.rbenv/versions/3.3.4/lib/ruby/gems/3.3.0/gems/better_html-2.1.1/lib/better_html/parser.rb:49:in `ast'
```
|
Can someone please take a look? |
|
Seems like this is not maintained anymore and I stopped using this gem |
|
I think now that we have herb, there is little reason to use this gem, but regardless I'll merge your PR. Sorry for the delay. |
|
Thank you! Indeed, I have since moved to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I stumbled across the following html snippet which crashes the parser:
<div foo=>bar</div>. The interpreted html from browsers (both chrome and firefox) is<div foo="">bar</div>so the generated ast with the fix seems to make sense to me.Error trace