Docs: Fix template_exclusion_filter explanation
#150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README.md
Outdated
| Defaults to `[/\Aon/i]` (matches `onclick` for example). | ||
| * `template_exclusion_filter`: This is called when determining whether to apply runtime checks on a `.erb` template. | ||
| When this `Proc` returns false, no safety checks are applied and parsing is done using the default Rails erubi engine. | ||
| When this `Proc` returns `true`, no safety checks are applied and parsing is done using the default Rails erubi engine. |
There was a problem hiding this comment.
Suggested change
| When this `Proc` returns `true`, no safety checks are applied and parsing is done using the default Rails erubi engine. | |
| When this `Proc` returns true, no safety checks are applied and parsing is done using the default Rails erubi engine. |
41687b6 to
e85d1d2
Compare
e85d1d2 to
f6d3b54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can see the preview here: https://github.com/Shopify/better-html/blob/41687b6ec969bfaaa7e505d84964c435364b2ec8/README.md
Fixes #137