Conversation
a720cd9 to
dbb7bd3
Compare
Coverage report
Test suite run success3764 tests passing in 1444 suites. Report generated by 🧪jest coverage report action from 54d4d3b |
dbb7bd3 to
3cc6b58
Compare
|
This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. |
3cc6b58 to
28c8da5
Compare
28c8da5 to
1ff8979
Compare
2c41f40 to
48c5296
Compare
|
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
| // Ensure shopify.app.toml exists in the app directory | ||
| await ensureAppToml(this.appDirectory) | ||
|
|
||
| // Ensure package.json exists in the app directory | ||
| await ensurePackageJson(this.appDirectory) |
There was a problem hiding this comment.
We were adding a default TOML and Json if for some reason they were not created, but that would mask actual errors.
48c5296 to
6d16a4a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
What is the impact of doing this on previous versions? Do all versions 3.84+ support the new schema? |
|
Yes, all versions above 3.84 (and much earlier) support the new schema, so this shouldn't have any impact. |
packages/app/src/cli/services/dev/app-events/file-watcher.test.ts
Outdated
Show resolved
Hide resolved
|
/snapit |
|
🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm. Test the snapshot by installing your package globally: npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/[email protected]Caution After installing, validate the version by running |
|
🤖 Code Review · #projects-dev-ai for questions ✅ Complete - No issues 📋 History✅ No issues → ✅ No issues |
7c40a28 to
54d4d3b
Compare
gonzaloriestra
left a comment
There was a problem hiding this comment.
@isaacroldan Thanks a lot for the careful review! I should have warned that there were many pending refactorings, but my plan was to tackle them later, as I already had this working and green.
Anyway, I think I solved all your comments now in this commit.
Regarding the subscriptions-reference-app template, it's not working in production. I'll ping them, but the template looks good in terms of schema, so this PR shouldn't change anything.
| get appIsEmbedded(): boolean { | ||
| return this.configuration.embedded |
There was a problem hiding this comment.
i'm not sure this is correct :thinking_face:
We use appIsEmbedded to actually set the default value of configuration.embedded
(see the function just below)
I think the creationDefaultOptions should use the appIsLaunchable to set the default value of embedded
There was a problem hiding this comment.
It's ok because the embedded value is set here, which happens first.
If you create an app, you will see that embedded = true is added, even if the template doesn't have it.
WHY are these changes introduced?
We have a lot of code to support the legacy app schema in the CLI and templates, but that schema only works for the template state (before linking), so it doesn't make sense to keep it.
The subscriptions-reference-app template is apparently ready, although
app initit's not working with the latest CLI version.WHAT is this pull request doing?
client_idrequired in app schema (templates must includeclient_id = "")[access_scopes]section)How to test your changes?
npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/[email protected]shopify app init --template=https://github.com/Shopify/shopify-app-template-react-router#add-client-id-to-tomlshopify app init --template=https://github.com/Shopify/shopify-app-template-none#add-client-id-to-tomlshopify app init --template=https://github.com/Shopify/shopify-app-template-remix#add-client-id-to-tomlshopify app init --template=https://github.com/Shopify/shopify-app-template-ruby#add-client-id-to-tomlshopify app init --template=https://github.com/Shopify/shopify-app-template-node#add-client-id-to-tomlshopify app init --template=https://github.com/Shopify/shopify-app-template-php#add-client-id-to-tomlshopify app init --template https://github.com/Shopify/shopify-app-template-react-router#include-declarative-definition-and-client-id(related to Support flexible templates forapp init#6751)shopify app dev,shopify app deploy...Measuring impact
How do we know this change was effective? Please choose one:
Checklist