revert changes from pr#3826 #3827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haribshahbaz
approved these changes
Jul 18, 2025
katiepeterso
approved these changes
Jul 18, 2025
ludoboludo
added a commit
that referenced
this pull request
Jul 21, 2025
* revert changes from pr#3826 (#3827) * bring back the release updates and version bump
NathanScheele
pushed a commit
to Misha-Puff/dawn
that referenced
this pull request
Sep 4, 2025
* revert changes from pr#3826 (Shopify#3827) * bring back the release updates and version bump
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
Some changes were introduced in PR #3826 though the approach in fixing the issue is causing regressions as per Scott comment on the PR.
I'm reverting those changes for now as I'm doing a release. We can look into fixing that different going forward.