Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: derive composite velocity and frequency units #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 10, 2025
Merged

feat: derive composite velocity and frequency units #15

merged 5 commits into from
Aug 10, 2025

Conversation

VPRamon
Copy link
Member

@VPRamon VPRamon commented Aug 9, 2025

Summary

  • represent unit ratios with a generic Per<N, D> and associated DivDim
  • define velocity and frequency units as simple aliases over Per
  • drop direct dependency on paste

Testing

  • cargo test (fails: VSOP87 codegen failed: Fetching VSOP87 directory listing)

https://chatgpt.com/codex/tasks/task_e_6897ca97268083338e959d5dd6f97338

@VPRamon VPRamon self-assigned this Aug 10, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 10, 2025 •
edited
Loading

Code Coverage

Package Line Rate Complexity Health
src.coordinates.transform 83% 0 ✔
src.units 81% 0 ✔
src.calculus.vsop87 70% 0 ➖
src.calculus.events 94% 0 ✔
src.coordinates 90% 0 ✔
src.coordinates.transform.centers.direction 83% 0 ✔
src.coordinates.spherical 91% 0 ✔
src.coordinates.transform.centers 100% 0 ✔
src.bodies 30% 0 ❌
src.calculus.solar 100% 0 ✔
src.astro 91% 0 ✔
src.coordinates.transform.centers.position 100% 0 ✔
src.coordinates.transform.frames 85% 0 ✔
src.targets 84% 0 ✔
src.coordinates.cartesian 68% 0 ➖
src.calculus.kepler_equations 98% 0 ✔
src 85% 0 ✔
src.calculus.elp2000 100% 0 ✔
Summary 85% (2532 / 2969) 0 ✔

VPRamon
VPRamon commented Aug 10, 2025
View reviewed changes
@VPRamon VPRamon merged commit ea45468 into dev Aug 10, 2025
1 check passed
@VPRamon VPRamon deleted the codex/refactor-units-to-use-phantom-types branch August 10, 2025 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@VPRamon VPRamon

Labels
codex
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@VPRamon