Allow saving empty secrets via secret manager and slash command#4580
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
There was a problem hiding this comment.
Reading empty secrets via slashcommand shows an unrelated and wrong error. Enabled allowKeysExposure in config, the secrets (and empty secrets) show up in the secret manager.
Calling this
/secret-read [your-secret-id-here] | /echo Secret: "{{pipe}}"
shows
It's not disabled though.
I mean, it outputs the correct value to the command, but likely only because very single slashcommand will always return '' on errors.
Nitpick, and not needed, but maybe nice.
Show some kind of indicator that there is an empty secret, in the secret manager. It just renders as... nothing.
Fixed in 1c2aedc
I don't dig fake empty values in the UI. And key exposure is not recommended anyway, so the possibility of someone to get confused is low. |
…yTavern#4580) * Allow saving empty secrets via secret manager and slash command Closes SillyTavern#4577 * Fix logic on cancel * Fix /secrets-read with empty secret value
…yTavern#4580) * Allow saving empty secrets via secret manager and slash command Closes SillyTavern#4577 * Fix logic on cancel * Fix /secrets-read with empty secret value
…yTavern#4580) * Allow saving empty secrets via secret manager and slash command Closes SillyTavern#4577 * Fix logic on cancel * Fix /secrets-read with empty secret value
Closes #4577
Checklist: