Skip TTS for voices explicitly set to disabled (fixes #4970)#5367
Conversation
|
@tgies alternatively, the toast notification can be displayed once per the character. That should be enough to see that something is wrong with the config, but not nag the user. accountStorage key-value can be used for that (check for its usage thru the project). |
a8e4af1 to
c5e9fc0
Compare
Cohee1207
left a comment
There was a problem hiding this comment.
It's better to always show the message for manual triggers, however for automated triggers we'll only show it once.
There was a problem hiding this comment.
Pull request overview
This PR updates the TTS extension to treat voices explicitly mapped to the disabled marker as “skip TTS” rather than failing the job, aiming to reduce user-facing errors when a character’s voice is intentionally disabled.
Changes:
- Adds a
manualflag to queued TTS jobs so the system can distinguish user-triggered narration from automatic narration. - Skips TTS generation when the resolved voice map entry is
disabled, including an account-level “warn once” mechanism. - Adjusts narration entry points to pass
manual: truefor some manual actions (single message +/speak).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Silently return instead of throwing an error or showing a toast when a voice is set to disabled.
Checklist: