add rule no-unused-expressions=off #698
Conversation
some chai tests may trigger the eslint no-used-expressions ``` ✘ http://eslint.org/docs/rules/no-unused-expressions Expected an assignment or function call and instead saw an expression path/to/test.spec.js:62:9 expect(await proxy[ID_APPARECCHIO]).to.not.be.undefined ^ ✘ 1 problem (1 error, 0 warnings) Errors: 1 http://eslint.org/docs/rules/no-unused-expressions ``` the solution is a copy & paste from [Eslint docs](https://eslint.org/docs/user-guide/configuring#disabling-rules-only-for-a-group-of-files)
There was a problem hiding this comment.
Hmm this is an interesting situation. While your solution does fix the issue, I'm not sure if it's the best option available. After doing some quick research there are a few different ways to address this issue. For instance there is an es lint plugin that correctly fixes this issue for the just the expressions affected.
https://www.npmjs.com/package/eslint-plugin-chai-friendly
[This] overrides the default
no-unused-expressionsrule and makes it friendly towards chai. The modified rule ignores theexpectandshouldstatements while keeping default behavior for everything else.
This could then be combined with your proposal to only use this plugin on test files:
// .eslintrc.js
module.exports = {
// ...
plugins: ['chai-friendly'],
overrides: [{
files: ['*-test.js', '*.spec.js'],
rules: {
'no-unused-expressions': 'off',
'chai-friendly/no-unused-expressions': 'off',
},
}],
// ...
}Note: we still disable no-unused-expressions per chai-friendly's documentation.
sourced from: https://stackoverflow.com/questions/37558795/nice-way-to-get-rid-of-no-unused-expressions-linter-error-with-chai
|
@XanderLuciano I like the plugin solution and. It's suggested by Pierre-Adrien Builsson in the post you linked. |
[eslint-plugin-chai-friendly](https://www.npmjs.com/package/eslint-plugin-chai-friendly)
|
Verified template still functions and passes test, merged PR. Thanks! |
some chai tests may trigger the eslint no-used-expressions
the solution is a copy & paste from Eslint docs