Documentation update for crystal collimators #1012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs and references
…s in crystal module
|
Thank you @vkbo and @amereghe for your comments. I implemented all your suggestions, added a couple more references as suggested by Daniele and removed the "to be implemented" note for crystals among the collimator families. I also added some comments in the crystal module to clarify the meaning of each process flag. |
vkbo
approved these changes
Nov 6, 2019
amereghe
approved these changes
Nov 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Special elements" section of the user manual has been updated with information on crystal collimators, including the description of the additional parameters required by the collimator database as well as appropriate references.