delete unused variables #1037
delete unused variables #1037
Conversation
There was a problem hiding this comment.
Hi @JamesMolson ,
thanks for the cleaning. I am not sure I would remove the unused parameters from the interfaces to expand arrays subroutines - I think it is fine to keep those there, as a general warning that expansion can take place, on all the main parameters impacting lattice structure / number of particles.
|
|
||
| contains | ||
|
|
||
| subroutine coll_expandArrays(npart_new, nblz_new) |
There was a problem hiding this comment.
I guess that here nblz_new was added to the interface just for the sake of completeness, such that in case one need to add stuff depending on the new number of lattice structures, the interface is already general enough
There was a problem hiding this comment.
It's probably no longer needed after we killed a bunch of collimation arrays.
source/main_da.f90
Outdated
| tas63,tas64,tas65 | ||
|
|
||
| character(len=8) cdate,ctime ! Note: Keep in sync with maincr. If the len changes, CRCHECK will break. | ||
| ! character(len=8) cdate,ctime ! Note: Keep in sync with maincr. If the len changes, CRCHECK will break. |
There was a problem hiding this comment.
why commenting this line out and not killing it, if it is not needed?
Is there some code that should be injected depending on these vars?
No description provided.