parsing unit of xp and yp in FORMAT keyword in DIST block
#1054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesMolson
approved these changes
Feb 13, 2020
|
For me it is ok. I merge... |
|
The changelog was not changed... |
|
Correct! Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presently, if the
xporypcolumns are present in aFORMATstatement, the unit stated by the user is ignored and the numbers are read in mrad. This is a problem in case of a file generated withgpdist(in the context of the Fluka-SixTrack coupling) in case of partially stripped ions or unstable hadrons, where the format of the file is non standard and aFORMATstatement is hence needed, butxpandypare expressed in rad and not in mrad.This PR aims at giving the possibility to parse the units of
xpandypin aFORMATstatement. Accepted values are[1], [1000], [RAD], [MRAD].User manual changed accordingly.