Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix building with gcc >=10 #1076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 17, 2021
Merged

Fix building with gcc >=10 #1076

merged 3 commits into from
Feb 17, 2021

Conversation

JamesMolson
Copy link
Contributor

So I tried to build with gcc/gfortran 10, and it currently does not.

This pr should fix that.

I had to disable building with distlib since it fails to link. The problem there seems to be a lack of header guards so the same variables are now pulled in multiple times and you get the same symbols defined multiple times. That would need to be fixed by @tpersson since it is in a separate repo.

crlibm had a similar issue which came from some internal diagnostic code that we don't need, so I just disabled that. This also should speed things up a tiny bit.

@rdemaria
Copy link
Contributor

rdemaria commented Feb 3, 2021

Thanks a lot! I will check with @tpersson ...

@rdemaria
Copy link
Contributor

rdemaria commented Feb 3, 2021

@JamesMolson could you confirm it is only a matter of adding #ifndef distlib #define distlib ...?

@JamesMolson
Copy link
Contributor Author

see as an example:
https://github.com/SixTrack/DISTlib/blob/master/source/distinterface.h

something like

#ifndef _distinterface_h_
#define _distinterface_h_

....

#endif

objects like dist, diststart, dim, etc etc are being pulled in multiple times. I really don't know why the linker in earlier versions was ok with that, but 10 is not (or could be something in binutils).

/cvmfs/sft.cern.ch/lcg/releases/binutils/2.34-990b2/x86_64-centos7/bin/ld: libdistlib.a(file_reader.c.o):(.bss+0x10): multiple definition of `dist'; libdistlib.a(distinterface.c.o):(.bss+0x10): first defined here
/cvmfs/sft.cern.ch/lcg/releases/binutils/2.34-990b2/x86_64-centos7/bin/ld: libdistlib.a(file_reader.c.o):(.bss+0x4): multiple definition of `dim'; libdistlib.a(distinterface.c.o):(.bss+0x4): first defined here
/cvmfs/sft.cern.ch/lcg/releases/binutils/2.34-990b2/x86_64-centos7/bin/ld: libdistlib.a(file_reader.c.o):(.bss+0x0): multiple definition of `distn'; libdistlib.a(distinterface.c.o):(.bss+0x0): first defined here
/cvmfs/sft.cern.ch/lcg/releases/binutils/2.34-990b2/x86_64-centos7/bin/ld: libdistlib.a(file_reader.c.o):(.bss+0x8): multiple definition of `diststart'; libdistlib.a(distinterface.c.o):(.bss+0x8): first defined here

etc

@rdemaria
Copy link
Contributor

I merge but distlib should be fixed...

@rdemaria rdemaria merged commit 704b578 into SixTrack:master Feb 17, 2021
@JamesMolson JamesMolson mentioned this pull request Feb 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpersson tpersson tpersson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JamesMolson @rdemaria @tpersson