EQV Fix #902
Merged
EQV Fix #902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Also removed a few that were a bit inconsistent
|
The precedence of .eqv. is indeed a little muddy. http://jick.net/Manuals/FORTRAN/g77/Equivalence-Versus-Equality.html |
amereghe
approved these changes
Jun 14, 2019
I replaced the ones in mod_alloc because they were inconsistent, and I was the one who put them there. I left the ones in the fringe field code be because those modules are maintained by someone else. .eqv. is technically the correct way to compare logicals though. But for simple if statements it's perhaps a bit overkill. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.eqv. operator doesn't have the precedence parts of the code assumes.
Also removed a few that were a bit inconsistent.