General particle transport for FLUKA #919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There probably also should be a fortran interface defined to the IO C functions. |
|
This is done for now |
vkbo
approved these changes
Aug 8, 2019
There was a problem hiding this comment.
Approving since @amereghe is not available and the coupling currently not working. This PR mostly concerns adding FlukaIO as a submodule.
I would still prefer it if the submodule was added under the lib folder with the other submodules. But we can address that later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This starts to add support for sending anything between SixTrack <--> FLUKA.
Do not merge (yet).
This needs to be merged at the same time as a number of other repos:
The FLUKA IO repo
The FLUKA coupling repo
otherwise everything will explode, since the communication is changing.
TODO here: make the IO repo a submodule.