Further Manual Updates #922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At least internally dpsv should be unscaled if I remember correctly.... |
|
You're right. It's in the tas matrix the factor 1000 comes in, not the array itself. Although dpsv1 is scaled. |
|
I would use the following rule: Value = Formula / Unit ejfv [MeV/c] This works also for xv xv [1/1000] Px/P means that xv=(Px/P)/(1/1000) |
rdemaria
approved these changes
Jul 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just looked at the variables definitions in the DUMP section.
I added the scaling factor for xp & yp, but for consistency, I removed those and updated the units instead. Also, the array variable for momentum was wrong.
The delta array should also be scaled by 1000, right?
Also, if ejfv is "Pc", shouldn't e0f be "P0 c"?