Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bugfixes in DIST, particle state and test suite #952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 28, 2019
Merged

Bugfixes in DIST, particle state and test suite #952

merged 6 commits into from
Aug 28, 2019

Conversation

vkbo
Copy link
Member

@vkbo vkbo commented Aug 28, 2019 •
edited
Loading

This PR fixes:

  • A bug in the interface to DISTlib. DISTlib expects geometric emittance, but normalised was sent.
  • Binary particle state files had the tas matrix that was not corrected for mm, mrad scaling, as opposed to the text version.
  • A test was missing in one of the lists in the test CMake so that it was not executed properly.
  • Fixed a variable in writebin that was forgotten in PR Keeping track of particle pairs #938 and sitting under the STF=OFF flag.

@vkbo vkbo requested review from rdemaria and tpersson August 28, 2019 13:40
@vkbo vkbo merged commit dddca40 into SixTrack:master Aug 28, 2019
@vkbo vkbo deleted the bugfixes branch August 29, 2019 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdemaria rdemaria rdemaria approved these changes

@tpersson tpersson Awaiting requested review from tpersson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vkbo @rdemaria