Onesided Collimators #958
Onesided Collimators #958
Conversation
…use DB settings for new DB
|
The PR is now complete and replaces the old feature for select onesided collimators. |
There was a problem hiding this comment.
Fine with me, thanks! Could you mention in the PR that you have also updated the doc, marking the new coll DB format as for production and the previous one, still supported, as old (actually, deprecated)?
Please note that I have made a couple of changes to the doc, and added parentheses in the conditional if-statement concerning LHC single sided collimators, to avoid mis-interpretations by the compiler (or humans). Please also not a couple of suggestions on treating angles larger (in module) than 2pi
avoiding truncation of line and compilation problems
There is no confusion for the compiler. The precedence of logical operators is well established and unambiguous. |
Since both the new jaw fit implementation and the crystals module need additional settings added to the database, I started adding the general parsing for this using onesided collimators as a starting point since this is mostly straight forward.
The PR is now complete and replaces the old feature for select onesided collimators.