Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

amereghe
Copy link
Contributor

@amereghe amereghe commented Sep 3, 2019

This PR aims at adding a couple of collimation tests to check the functionalities concerning jaw fitting, one-sided collimators and random tilting/offsetting/opening. To do so in an optimal way, a dump of the particle positions at the entrance and exit of jaws has been implemented.

Tests are also provided with a plotting script, for a visual inspection of the results.

…iles.dat') where jaw entrance and exit points are noted down.

At the same time, increased dump of jaw fit points to lout to have all points (last one was missing)
…c about single-sided collimators, as single-sided can be triggered via fort.3 only for TCPs and always positive side (no possibility to flip side via collimator skew angle).
@amereghe
Copy link
Contributor Author

amereghe commented Sep 3, 2019

What's written in the manual concerning one-sided collimators is bullshit:

  • the knob in fort.3 affects only TCP collimators;
  • only positive jaws are treated. Negative ones cannot be treated by changing the skew angle by pi, as claimed by the documentation;
  • the NAME_SEL knob in fort.3 has nothing to do with single sided collimation.

@amereghe amereghe requested a review from vkbo September 3, 2019 14:01
@amereghe
Copy link
Contributor Author

amereghe commented Sep 3, 2019

Hi @vkbo ,
the idea is to merge this into master, then update the test in your PR #933, and then merge it. What do you think?

@amereghe amereghe changed the title WIP Jaw profiling Jaw profiling Sep 3, 2019
@amereghe amereghe mentioned this pull request Sep 3, 2019
@amereghe amereghe changed the title Jaw profiling WIP: Jaw profiling Sep 4, 2019
@amereghe amereghe changed the title WIP: Jaw profiling Jaw profiling Sep 4, 2019
Copy link
Member

@vkbo vkbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Just a couple of minor things to be consistent with changes to be merged later.

* 'JawProfiles.dat' into 'jaw_profiles.dat';
* formatted header -> same format extended to actual content of file;
* made linside var scalable with napx not via alloc;
@vkbo
Copy link
Member

vkbo commented Sep 9, 2019

Your new tests are now failing.

@amereghe
Copy link
Contributor Author

amereghe commented Sep 9, 2019

yes, I know, I am committing/pushing things in steps - I will push the updated canonical in few minutes

@vkbo vkbo merged commit a0abeae into SixTrack:master Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants