-
Notifications
You must be signed in to change notification settings - Fork 44
Kill non-STF build option #967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Great! Only comment is that it could be useful to have a STF-to-FORT90ish converter, for legacy users. |
Maybe it would be better to just have a standalone executable. I doubt anyone relying on this uses SixTrack 5.x anyway. I assume the code can be extracted from pospr or read90? |
For what it's worth, the converter was written and can be seen in: It works, but needs to be integrated with the build and test system. It should probably also accept a flag to write the old-style fort.91-i filenames. |
The PR to Veronica's branch is now ready to be merged. It should probably also be tested with ntwin=1... |
Thanks for merging that. Only thing that one should look at is that the test for the conversion tool is currently referencing the |
After this has come up again, Riccardo and I agreed that it was time to discuss deleting the non-STF option. It keeps causing issues with the test suite as we have to disable tests that use more than 64 particles but otherwise checks important parts of the code. It also means we no longer need to maintain a duplicate set of track files for all tests that uses these.
This PR removes all of the STF flags from the code and locks it to always use the singletrackfile option. It's been the default for a while now too. Documentation is also updated.