Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Minor Bugfix on Collimation Exit #976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 20, 2019
Merged

Minor Bugfix on Collimation Exit #976

merged 1 commit into from
Sep 20, 2019

Conversation

vkbo
Copy link
Member

@vkbo vkbo commented Sep 19, 2019

The exit routine in collimation is called with a different condition than the init routine, causing the final summary files to not be written when running a thin 4D setup.

amereghe
amereghe approved these changes Sep 20, 2019
View reviewed changes
Copy link
Contributor

@amereghe amereghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just for the record: (this)[https://github.com/SixTrack/SixTrack/commit/991af00f00e75803277c119119da4baec8e132ac) is the commit where the condition wrapping collimate_init was changed

@vkbo
Copy link
Member Author

vkbo commented Sep 20, 2019

The init call was fixed in PR #931

@vkbo vkbo merged commit 081bf17 into SixTrack:master Sep 20, 2019
@vkbo vkbo deleted the coll_fixes branch October 4, 2019 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amereghe amereghe amereghe approved these changes

@JamesMolson JamesMolson Awaiting requested review from JamesMolson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vkbo @amereghe