[Step 5] Collimation File & Variable Cleanup #987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lement, so call that instead
…o a separate subroutine
…mplitude flag decide array allocations.
… and on dpop following the logic of code
amereghe
approved these changes
Oct 29, 2019
There was a problem hiding this comment.
Hi @vkbo ,
thanks a lot for the work.
Please remember to report in the description of the PR that:
- you add also a flag for triggering the use of the efficiency arrays (defaulting to false);
twisslike.outhas been removed;- the collDB is now fully dyn allocated;
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR includes the previous steps, so the diff is huge until these are merged.
This PR cleans up some of the output files that had a
*format. It also removes a number of unused variables and arrays, and move a lot of variables from the collimation module header to subroutines when these variables are not shared between routines.In addition, a flag has been added for enabling the efficiency code and output, which by default is disabled.
The
twisslike.outfile has been merged intosigmasettings.outas those files were containing a lot of the same information already.