Shared client data root and one transfer protocol - #526
Open
Skidamek wants to merge 14 commits into
Open
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 73dbc8afac
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Remove refresh from the wire protocol, share frame and pipeline handling, centralize generation publication and login state, and promote verified CAS objects through a target-local temporary file when storage roots use different filesystems.
Skidamek
force-pushed
the
gen/shared-storage
branch
from
September 2, 2026 19:55
73dbc8a to
12ffbbb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Client data moves out of the game directory, and the blocking and Netty transfer paths collapse into one protocol.
DataRootResolverpicks and pins a shared operating-system data root, with a game-local fallback. The active projection and transaction state stay with the game; shared objects, generation records, caches, pack connections, and origin trust data live under the resolved root. Overlay tombstones and their digest are stored with the client state.Server generation storage gets explicit records, catalogues, commits, deltas, current state, and compaction, and standalone servers use the same layout. The store can measure and collect unreferenced objects, keep patch-note history, and repair a missing current projection.
ProtocolFrameCodecis the one length and compression codec for both transfer paths, andProtocolPipelineinstalls the same Netty handlers on regular and holepunch connections. Downloads validate size and hash, and trust data is keyed by connection origin instead of a raw IP address.The client, the standalone server, and the update screens switch to the new roots and transfer code. Preload acquires the selected generation's objects without touching the active projection.
Tests
Shared storage, cache collection, protocol framing, trust, standalone server, and downloads.
Later layers
#533 replaced the server-side records, catalogues, and commits with the content journal. The data root split, the protocol codec, and the origin trust store survived.