Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix potential resolution failure with single list parameter function calls #8071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 25, 2025
Merged

Fix potential resolution failure with single list parameter function calls #8071

merged 2 commits into from
Jul 25, 2025

Conversation

APickledWalrus
Copy link
Member

Problem

Function calls for single list parameter functions could fail to resolve. Consider the example:

function test(p: potion effect types):
	stop
on load:
	test(night vision and glowing)

The function registry should be able to resolve this, but it fails to do so. However, this does not occur with all types. After some investigation, I found that the converterExists check for resolving these single list parameter functions had the parameters mistakenly swapped.

Solution

I swapped the parameters which resolved the issue.

Testing Completed

I have included a regression test.

Supporting Information

Completes: #8070
Related: none

@APickledWalrus APickledWalrus requested a review from Efnilite as a code owner July 22, 2025 20:58
@APickledWalrus APickledWalrus added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Jul 22, 2025
@APickledWalrus APickledWalrus requested a review from a team as a code owner July 22, 2025 20:58
@APickledWalrus APickledWalrus requested review from cheeezburga and removed request for a team July 22, 2025 20:58
@skriptlang-automation skriptlang-automation bot added the needs reviews A PR that needs additional reviews label Jul 22, 2025
@APickledWalrus APickledWalrus changed the base branch from master to dev/patch July 22, 2025 20:58
@skriptlang-automation skriptlang-automation bot added patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. and removed needs reviews A PR that needs additional reviews labels Jul 22, 2025
@github-project-automation github-project-automation bot moved this to Awaiting Merge in 2.12 Releases Jul 23, 2025
@APickledWalrus APickledWalrus linked an issue Jul 24, 2025 that may be closed by this pull request
Functions with plural params not recognized #8070
Closed
1 task
@APickledWalrus APickledWalrus merged commit 74ad10c into SkriptLang:dev/patch Jul 25, 2025
5 checks passed
@APickledWalrus APickledWalrus deleted the patch/plural-function-arguments branch July 25, 2025 15:12
@github-project-automation github-project-automation bot moved this from Awaiting Merge to Done - Awaiting Release in 2.12 Releases Jul 25, 2025
@sovdeeth sovdeeth moved this from Done - Awaiting Release to Done - Released in 2.12 Releases Aug 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sovdeeth sovdeeth sovdeeth approved these changes

@Absolutionism Absolutionism Absolutionism approved these changes

@TheMug06 TheMug06 TheMug06 approved these changes

@Efnilite Efnilite Awaiting requested review from Efnilite Efnilite is a code owner

@cheeezburga cheeezburga Awaiting requested review from cheeezburga cheeezburga is a code owner automatically assigned from SkriptLang/core-developers

Assignees
No one assigned
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version.
Projects
2.12 Releases
Status: Done - Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Functions with plural params not recognized
4 participants
@APickledWalrus @sovdeeth @Absolutionism @TheMug06