Improve default syntax ordering #8076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Absolutionism
approved these changes
Jul 24, 2025
sovdeeth
requested changes
Jul 25, 2025
src/main/java/org/skriptlang/skript/registration/SyntaxRegister.java
Outdated
Show resolved
Hide resolved
sovdeeth
approved these changes
Jul 25, 2025
|
We may also consider improving this in the future by storing compiled patterns on every SyntaxInfo and instead iteratoring over the pattern elements. That requires a more complex rework, so this should suffice for a patch. |
Efnilite
approved these changes
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#7879 changed syntax ordering so that it was no longer dependent on when the syntax was registered. However, most syntax is not using Priority yet, meaning more complex syntax (i.e. harder to parse) such as EffVisualEffect is being attempted early on in some cases (when it should instead be saved for last).
Solution
While these more complex syntaxes should have a higher priority, I have created a simple metric for determining the "complexity" of a syntax. Currently, the metric simply considers how many percent signs a pattern contains (they have not yet been compiled and i didn't think it was worth doing that). The idea is that
percent signs = expressionsandmore expressions = more complex(harder to parse) which is generally trueTesting Completed
n/a
Supporting Information
Completes: none
Related: none