Fix ExprLoopValue matching too loosely due to canReturn() #8090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Absolutionism
approved these changes
Jul 28, 2025
APickledWalrus
approved these changes
Jul 28, 2025
Efnilite
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Accidental breaking changes were caused due to changes to ExprLoopValue where existing typed loop value expressions (
loop-player) suddenly started matching other parent loops likeloop {var::*}due to a change to use canReturn which always returns true if the return class is Object.Solution
Reverts the change that added canReturn. This isn't a perfect solution but in the interest of 2.12.1 and fixing breaking changes, it's the most expedient. Also cleans up some poorly named variables.
Testing Completed
added regression test.
Supporting Information
Completes: none
Related: none