This repository was archived by the owner on Jun 14, 2023. It is now read-only.
fix: RandomSampler may get sampled when samplingRate is 0 #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #119 +/- ##
=======================================
Coverage 67.48% 67.48%
=======================================
Files 17 17
Lines 735 735
=======================================
Hits 496 496
Misses 195 195
Partials 44 44
Continue to review full report at Codecov.
|
mrproliu
approved these changes
Jun 29, 2021
Contributor
mrproliu
left a comment
There was a problem hiding this comment.
Thank you for contributing. LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #101