feat: add validity check for span #141
Conversation
Codecov Report
@@ Coverage Diff @@
## master #141 +/- ##
==========================================
+ Coverage 69.32% 69.82% +0.49%
==========================================
Files 17 17
Lines 890 898 +8
==========================================
+ Hits 617 627 +10
+ Misses 226 224 -2
Partials 47 47
Continue to review full report at Codecov.
|
2c88168 to
3287538
Compare
noop.go
Outdated
| } | ||
|
|
||
| func (*NoopSpan) IsValid() bool { | ||
| return false |
There was a problem hiding this comment.
I think it is better to keep no-op span always valid? The codes would expect a span valid in most cases, right?
There was a problem hiding this comment.
The reason I think about this is, if return false always, we will face a case a new created span is Invalid, which could cause some unexpected bugs switching from tracing to noop mode.
There was a problem hiding this comment.
Yeah it's true, I thought about it for a while, the only side-effect is the no-op span is always be valid, even after callling End, I will modify it
Now the
Span.End()method will get panic when call it repeatedly, to improve the robustness, we can add aIsValidmethod to check if the current span is still valid in the context, and according to SkyAPM/go2sky-plugins#40 (comment), we can provide this method to avoid creating a span from a invalid parent spanFor a valid span, the
EndTimevalue shoud be zero, and after callEnd(), it will be assigned the value oftime.Now(), so I check this value to determine if current span is valid:This PR will add a new method to the
Spaninterface, so we may need to consider if it caused a break change and it may not be thread-safe in some concurrency scenarios.