Display SlimeVR Tracker Battery Life#41
Merged
Merged
Conversation
Added SlimeVR-specific tracker icons to be used, removed old icons which were unused.
Co-authored-by: Butterscotch! <[email protected]>
Added support for trackers reporting: - Battery percentage - When charging (Battery voltage >=4.2V; guesstimate, maybe needs to be changed)
Member
|
The only thing battery voltage is used for here is for detecting if the tracker is charging or not, correct? I'd rather kick charging detection into firmware (or at least server for now) (i.e. the device reports the right thing depending on the setup) and just receive a boolean is_charging in driver. |
Replaced battery_voltage with is_charging, and added sending HMD battery to server.
SteamVR applies a blue-green gradient to tracker icons at runtime and creates a ".b4bfb144" version if one is not present. Blue-green ".b4bfb144" tracker icons do already exist and therefore these are used instead of SteamVR generating redundant ".b4bfb144.b4bfb144" icons.
kitlith
approved these changes
May 22, 2023
Eirenliel
approved these changes
Jun 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for receiving tracker battery info from the SlimeVR Server.
This depends on another pull request. (SlimeVR/SlimeVR-Server#668)