Fix bug in RSSParser where feed relative links are not properly handled #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nijssen
commented
Jan 31, 2021
| if (!link) { | ||
| link = node.querySelector('link[type="text/html"]'); | ||
| } | ||
| if (!link) { |
Author
There was a problem hiding this comment.
This code appears to be duplicated so I removed it
Collaborator
|
Thanks, I'll take a look to see if it doesn't skip any earlier covered corner cases and if I don't notice any issues I'll pull it in. As of the release task it's mostly for my own convenience, it creates ready to publish packages with version changed accordingly and should be used only for that but don't worry about that too much as it's a non-issue as long as there are no conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some feeds (example) the
links are not absolute URLs containing the domain, so then the item's link looks likechrome-extension://.../path-on-the-authors-site/.This PR fixes that issue. Tested on Opera 73.0.3856.344 on Windows 10 (but I doubt it matters).
By the way, I ran the
releasetask...hope that was the intention?