Thanks to visit codestin.com
Credit goes to github.com

Skip to content

wayland.selection: Introduce ext data control protocol #1577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Drakulix merged 3 commits into from
Feb 10, 2025
Merged

wayland.selection: Introduce ext data control protocol #1577

Drakulix merged 3 commits into from
Feb 10, 2025

Conversation

@PolyMeilex
Copy link
Member

@PolyMeilex PolyMeilex commented Nov 3, 2024 •
edited
Loading

  • wayland.selection: ExtDataControl Adds support for the new ext data control protocol
  • wayland.selection: Introduce DataDeviceKind Removes TypeId in favor of DataDeviceKind enum

@PolyMeilex PolyMeilex mentioned this pull request Nov 3, 2024
Open
@PolyMeilex PolyMeilex force-pushed the ext-data-control branch 5 times, most recently from 9eb0022 to f4fc2f2 Compare December 26, 2024 00:41
@PolyMeilex PolyMeilex added this to the v0.5: The nameless smith milestone Jan 24, 2025
@ids1024 ids1024 mentioned this pull request Jan 30, 2025
Merged
@ids1024
Copy link
Member

ids1024 commented Jan 31, 2025

wayland-protocols 0.32.6 is now released on crates.io.

@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 326 lines in your changes missing coverage. Please review.

Project coverage is 19.17%. Comparing base (953959e) to head (ac7c63b).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
src/wayland/selection/ext_data_control/mod.rs 0.00% 84 Missing ⚠️
src/wayland/selection/ext_data_control/device.rs 0.00% 69 Missing ⚠️
src/wayland/selection/device.rs 0.00% 48 Missing ⚠️
src/wayland/selection/offer.rs 0.00% 38 Missing ⚠️
src/wayland/selection/source.rs 0.00% 35 Missing ⚠️
src/wayland/selection/ext_data_control/source.rs 0.00% 32 Missing ⚠️
src/wayland/selection/wlr_data_control/mod.rs 0.00% 8 Missing ⚠️
src/wayland/selection/wlr_data_control/device.rs 0.00% 7 Missing ⚠️
src/wayland/selection/seat_data.rs 0.00% 5 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1577      +/-   ##
==========================================
+ Coverage   17.33%   19.17%   +1.84%     
==========================================
  Files         171      174       +3     
  Lines       28389    28689     +300     
==========================================
+ Hits         4922     5502     +580     
+ Misses      23467    23187     -280
Flag Coverage Δ
wlcs-buffer 16.71% <0.00%> (-0.11%) ⬇️
wlcs-core 16.45% <0.00%> (-0.11%) ⬇️
wlcs-output 6.81% <0.00%> (-0.01%) ⬇️
wlcs-pointer-input 18.15% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PolyMeilex PolyMeilex marked this pull request as ready for review February 1, 2025 15:56
@PolyMeilex
Copy link
Member Author

PolyMeilex commented Feb 1, 2025

This is now ready.

kchibisov
kchibisov reviewed Feb 1, 2025
View reviewed changes
Copy link
Member

@kchibisov kchibisov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would assume that the implementation of request handling was copy pasted 1 to 1 from the Wlr one, with the exception of removed version checks.

@PolyMeilex PolyMeilex requested a review from Drakulix February 9, 2025 18:31
kchibisov
kchibisov approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member

@kchibisov kchibisov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The integration with the rest looks fine, if the code is exact copy of wlr ( I think it's fine ).

Drakulix
Drakulix approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member

@Drakulix Drakulix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well :)

@Drakulix Drakulix merged commit 10d03af into Smithay:master Feb 10, 2025
13 checks passed
@PolyMeilex PolyMeilex deleted the ext-data-control branch February 10, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Drakulix Drakulix Drakulix approved these changes

+1 more reviewer

@kchibisov kchibisov kchibisov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.5: The nameless smith

Development

Successfully merging this pull request may close these issues.

5 participants

@PolyMeilex @ids1024 @codecov-commenter @Drakulix @kchibisov