Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@m4rch3n1ng
Copy link
Contributor

@m4rch3n1ng m4rch3n1ng commented May 18, 2025

i had to do 4 changes for the update:

  1. i had to enable the "pipe" and "process" features. i think those were enabled by a transitive dependency on rustix, that had already enabled them, but since those were enabling them for rustix 0.38, i had to enable them explicitly for rustix 1.0.
  2. similar to update to rustix 1.0 and bump linux-raw-sys drm-rs#223, i had to change the generic for rustix::ioctl from a type to a const.
  3. rustix::event::poll changed the type from a c_int to an Option<&Timespec>. since the timeout was 0, i don't have to convert anything and only construct a 0-ed Timespec. i opted against using Timespec::default as i thought that doing it this way was more clear.
  4. rustix merged all of the rustix::net::bind_* fns into a single rustix::net::bind that takes an &impl SocketAddrArg

as far as i can tell, none of the "silent behavior changes" mentioned in rustix's CHANGES.md apply here.

i tested this locally with my own compositor and everything worked just fine (though i don't use all of smithay there).

i realised that i forgot some functions that were not compiled on linux. in the second commit in [a2171c8], i (attempt to) fix the rustix errors for non-linux, non-android and non-freebsd targets, but i cannot actually check if they are working, as i do not have access to an openbsd machine or similar. additionally, i believe that function already doesn't compile, as it was forgotten to be updated when rand got bumped in #1703.

Copy link
Member

@Drakulix Drakulix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Drakulix Drakulix merged commit 88d638f into Smithay:master May 22, 2025
12 of 13 checks passed
@m4rch3n1ng m4rch3n1ng deleted the rustix-1 branch May 22, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants