Homework Week 2 Midy #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homework/index.js
Outdated
| function renderRepoDetails(repo, ul) { | ||
| createAndAppend('li', ul, { text: repo.name }); | ||
| function renderRepoDetails(repo, parent) { | ||
| console.log(repo); |
There was a problem hiding this comment.
Please remove any console.log statements used for debugging before committing
| // This here finds the index of the repo we are looking for | ||
| // using the value selected in `select` | ||
| renderRepoDetails( | ||
| repos[repos.findIndex(el => el.name === select.options[select.selectedIndex].value)], |
There was a problem hiding this comment.
It is better to use this instead of select here in order to make this function reusable if needed
|
Homework week 3 is here too for some reason! |
| } | ||
| return res.status === 200 ? res.json() : null; | ||
| }); | ||
| static async fetchJSON(url) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.